Page MenuHomePhabricator

Special page redirects should preserve safemode parameter
Closed, ResolvedPublic

Description

(Related to T37060.)

[[Special:MyPage]] should preserve the safemode parameter. This would be particularly useful as Special:MyPage/common.css?action=edit&safemode=true , for linking users to if they've accidentally locked themselves out of being able to edit their own CSS or JS. This would allow them to easily remove the accidental CSS/JS bug by themselves, without needing to ask an interface admin or go through the complicated step of turning off their own CSS or JS locally via their browser.

Event Timeline

Based on fixes to similar bugs, this could presumably be fixed by changing line 227 of mediawiki/includes/specialpage/RedirectSpecialPage.php from
'redlink',
to
'redlink', 'safemode',
...

DannyS712 subscribed.

I can do this, but the edit you suggest would apply to all redirect special pages (Special:MyPage, Special:MyLanguage, etc.). This would probably be a good thing, but I just want to make sure it is okay.

Agree, having all redirect special pages work preserve safemode would be a good thing.

Change 520742 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add safemode to special redirect parameters that are preserved

https://gerrit.wikimedia.org/r/520742

Change 520742 merged by jenkins-bot:
[mediawiki/core@master] Add safemode to special redirect parameters that are preserved

https://gerrit.wikimedia.org/r/520742

DannyS712 renamed this task from Special:MyPage should preserve safemode parameter to Special page redirects should preserve safemode parameter.Jul 22 2019, 8:10 AM