Page MenuHomePhabricator

Missing icons and a broken link in OOUI tutorials toolbar
Closed, ResolvedPublic

Description

I spotted a couple of problems with the tutorials toolbar, and I've explored them a bit with Moriel and Roan.

  1. The Docs link is broken. It comes from
demos/tutorials/widgets/toolbar.js

I think it can be fixed by replacing "oojs-ui/master/js" with "js/" on line 29.

  1. Toolbar menu icons load locally, but not on doc.wikimedia.org. The submenu links are loaded from
dist/oojs-ui-wikimediaui-icons-content.css

and can be seen both locally and in production. We think the missing links come from

dist/oojs-ui-wikimediaui-icons-editing-citation.css

so a link to this file should be added to all 3 HTML files:

tutorials/index.html
tutorials/collection/basics1/contents.html
tutorials/collection/basics2/contents.html

However, we're not sure why the missing links do load locally, while a link to this CSS file is missing.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2018, 8:25 AM
Hagarshilo updated the task description. (Show Details)Aug 16 2018, 11:53 AM
Hagarshilo updated the task description. (Show Details)Aug 16 2018, 3:34 PM

Change 453169 had a related patch set uploaded (by Hagar Shilo; owner: Hagar Shilo):
[oojs/ui@master] Restore missing icons and fix broken Docs link in OOUI tutorials toolbar

https://gerrit.wikimedia.org/r/453169

Change 453169 merged by jenkins-bot:
[oojs/ui@master] Restore missing icons and fix broken Docs link in OOUI tutorials toolbar

https://gerrit.wikimedia.org/r/453169

However, we're not sure why the missing links do load locally, while a link to this CSS file is missing.

Several icons were recently moved to different files, you might not have updated your local repository yet.

Hagarshilo closed this task as Resolved.Aug 16 2018, 8:59 PM
Hagarshilo triaged this task as Normal priority.
Volker_E removed a subscriber: gerritbot.