Page MenuHomePhabricator
Create Task
Maniphest T202059

Bug in Chrome with Cyrillic strings in CodeEditor, cursor position shows on the wrong place
Closed, DuplicatePublic
Actions

Description

Bug with Cyrillic strings in lua scripts, cursor position shows on the wrong place

Related Objects

Event Timeline

Eugene created this task.Aug 16 2018, 2:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2018, 2:00 PM
Eugene assigned this task to Krinkle.Aug 16 2018, 2:02 PM

You can try to edit Cyrillic strings in https://uk.wikipedia.org/w/index.php?title=%D0%9C%D0%BE%D0%B4%D1%83%D0%BB%D1%8C:Wikidata&action=edit

Eugene added a subscriber: NickK.Aug 16 2018, 2:04 PM

@NickK Can you add a comment?

Eugene added a subscriber: MBH.Aug 16 2018, 2:05 PM

@MaxBioHazard

Aklapper changed the task status from Open to Stalled.Aug 16 2018, 3:12 PM

Hi @Eugene, thanks for taking the time to report this!
Did Krinkle explicitly agree on being the assignee of this task?
Unfortunately this report lacks some information. If you have time and can still reproduce the problem: Please add a more complete description to this report by providing a clear list of specific steps to reproduce the situation, as little details sometimes matter, so that nobody needs to guess how you performed each step, and by describing actual results and by describing expected results after performing the steps to reproduce, plus information about your web browser(s) tested.
You can edit the task description by clicking Edit Task. Thanks!

Eugene added a comment.Aug 16 2018, 4:03 PM

@Aklapper I have just added Krinkle myself, I do not know will he agree or not to solve this problem. The bug occurs when you edit lua scripts with Cyrillic strings. For example in https://uk.wikipedia.org/w/index.php?title=%D0%9C%D0%BE%D0%B4%D1%83%D0%BB%D1%8C:Wikidata&action=edit

If you put cursor inside Cyrillic string and then try to type anything, you will see that typing happend to be 5 or 6 symbols to the left from cursor position.

Aklapper removed Krinkle as the assignee of this task.Aug 16 2018, 4:23 PM
Aklapper added a subscriber: Krinkle.

I do not know will he agree or not to solve this problem.

Ah, thanks. Removing the assignee as it's up to each person what they plan to work on. :)

If you put cursor inside Cyrillic string and then try to type anything, you will see that typing happend to be 5 or 6 symbols to the left from cursor position.

I've set my keyboard to Russian now (sorry :) ) and I entered some text in https://uk.wikipedia.org/w/index.php?title=Модуль:Wikidata&action=edit (which uses CodeEditor for me) in Firefox 61 on Linux. The cursor was always where I expected it. So we need better steps that allow someone else to reproduce.

Please [[ https://www.mediawiki.org/wiki/Help:Locating_broken_scripts | try with safemode enabled ]] and please provide browser and browser version information.

Krinkle unsubscribed.Aug 16 2018, 4:49 PM
Eugene added a comment.Aug 16 2018, 5:37 PM

I work with MacOS High Sierra, Chrome Version 68.0.3440.106 (Official Build) (64-bit)

You should type inside the Cyrillic string, for instance "Невідомий тип сутності"

Aklapper added a comment.Aug 16 2018, 5:39 PM

I did that. No problems.
Again: Please try with safemode enabled. Please also try when being logged out in a private browser window; and if possible also with another browser. Thanks!

Krinkle added projects: CodeEditor, VisualEditor.Aug 16 2018, 5:42 PM
Eugene added a comment.Aug 16 2018, 5:56 PM

Oh, in Safari this bug does not occur! But in Chrome it occurs also in Windows and in a private browser window

Eugene renamed this task from Bug with Cyrillic strings in lua scripts, cursor position shows on the wrong place to Bug in Chrome with Cyrillic strings in lua scripts, cursor position shows on the wrong place.Aug 16 2018, 5:57 PM
Aklapper added a project: Browser-Support-Google-Chrome.Aug 16 2018, 6:36 PM

Also see the requests in T202059#4507641

(Is VisualEditor involved at all here?)

Eugene added a comment.Aug 16 2018, 9:05 PM

I don't think that VisualEditor is involved, it is turned off in my settings.

Eugene removed a project: VisualEditor.Aug 16 2018, 9:06 PM
Eugene added a comment.Aug 16 2018, 9:22 PM

I found the same ticket!!! https://phabricator.wikimedia.org/T200741 Could someone merge them?

Eugene added a comment.Aug 16 2018, 9:42 PM

the issue is also present with Unicode text consisting of more then 1 byte per character

Aklapper added a comment.Aug 17 2018, 8:11 AM
In T202059#4508373, @Eugene wrote:

Could someone merge them?

You can. :) Click Edit Related Tasks → Close As Duplicate.

Eugene renamed this task from Bug in Chrome with Cyrillic strings in lua scripts, cursor position shows on the wrong place to Bug in Chrome with Cyrillic strings in CodeEditor, cursor position shows on the wrong place.Aug 17 2018, 8:12 AM
Eugene closed this task as a duplicate of T200741: Editing site JS results in unexpected behaviour.
Aklapper mentioned this in T212680: Cursor off by several lines where the text is edited in new wikitext mode.Dec 29 2018, 2:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL