Page MenuHomePhabricator

ProofreadPage PHPUnit tests failing on master (failure related to 'hadSignature')
Closed, ResolvedPublic

Description

ProofreadPage PHPUnit tests are currently failing on master. Example failing patch: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ProofreadPage/+/451834

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/7779/console

15:40:43 There were 2 failures:
15:40:43 
15:40:43 1) ProofreadPage\Index\IndexContentTest::testPreSaveTransform with data set #0 (ProofreadPage\Index\IndexContent Object (...), ProofreadPage\Index\IndexContent Object (...))
15:40:43 Failed asserting that two objects are equal.
15:40:43 --- Expected
15:40:43 +++ Actual
15:40:43 @@ @@
15:40:43  ProofreadPage\Index\IndexContent Object (
15:40:43      'fields' => Array (
15:40:43          'foo' => WikitextContent Object (
15:40:43              'redirectTargetAndText' => null
15:40:43 -            'hadSignature' => false
15:40:43 +            'hadSignature' => true
15:40:43 
15:40:43 /workspace/src/extensions/ProofreadPage/tests/phpunit/Index/IndexContentTest.php:153
15:40:43 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
15:40:43 /workspace/src/maintenance/doMaintenance.php:94
15:40:43 
15:40:43 2) ProofreadPage\Page\PageContentTest::testPreSaveTransform with data set #0 (ProofreadPage\Page\PageContent Object (...), ProofreadPage\Page\PageContent Object (...))
15:40:43 Failed asserting that two objects are equal.
15:40:43 --- Expected
15:40:43 +++ Actual
15:40:43 @@ @@
15:40:43  ProofreadPage\Page\PageContent Object (
15:40:43      'header' => WikitextContent Object (
15:40:43          'redirectTargetAndText' => null
15:40:43 -        'hadSignature' => false
15:40:43 +        'hadSignature' => true
15:40:43          'mText' => 'hello this is [[Special:Contr....0.1]]'
15:40:43          'model_id' => 'wikitext'
15:40:43      )
15:40:43      'body' => WikitextContent Object (
15:40:43          'redirectTargetAndText' => null
15:40:43 -        'hadSignature' => false
15:40:43 +        'hadSignature' => true
15:40:43 
15:40:43 /workspace/src/extensions/ProofreadPage/tests/phpunit/Page/PageContentTest.php:199
15:40:43 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
15:40:43 /workspace/src/maintenance/doMaintenance.php:94
15:40:43 
15:40:43 FAILURES!
15:40:43 Tests: 2740, Assertions: 26088, Failures: 2.

Event Timeline

matmarex triaged this task as Unbreak Now! priority.Aug 16 2018, 7:34 PM
matmarex created this task.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptAug 16 2018, 7:34 PM

Change 453193 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/ProofreadPage@master] Fix failing tests

https://gerrit.wikimedia.org/r/453193

Change 453193 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Fix failing tests

https://gerrit.wikimedia.org/r/453193

matmarex closed this task as Resolved.Aug 16 2018, 8:19 PM