@Ejegg my understanding is that in the meantime it's possible to add a column no_thank_you to the csv & put a zero in it & emails will go out?

Ooh, if that's the case, I can go ahead and do that for July's reconciliation.

@jkim_wikimedia maybe just try one or 2 first with the column 'no_thank_you' & check how it goes - if the thank you then goes out you should be able to see thank you sent update

Shoot, we're still using this in the query to get the batch of donations to send thank you letters for:

WHERE
 receive_date > :earliest AND
 thankyou_date IS NULL AND
 no_thank_you IS NULL

So '0' won't do the trick, unfortunately. We'll need to change that in the code.

Yeah, it didn't work. I can just import and do thank you emails manually this month since Leanne needs the totals in soon.

Hey all, the direct mail appeal from the import wasn't added either.

Got a patch that should allow '0' or '', but we might need to clean up T97684 first

Change 453429 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] '0' or blank no_thank_you means send email

https://gerrit.wikimedia.org/r/453429

Change 453429 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] '0' or blank no_thank_you means send email

https://gerrit.wikimedia.org/r/453429

Oops, can't deploy that till we figure out what to do with Engage donations. Turns out they end up with a blank in the no_thank_you field which till now has meant we don't send an automatic letter.

@RLewis can you remind me why we don't want to send automatic thank you letters to donors entered by Engage? Is that the case for ALL donations entered by hand?

If we want to continue omitting automatic TY letters for all donations entered by hand, let's put a default value like 'manually entered' for the "No thank you reason" on the form.

Let's add @LeanneS to this thread since Rosie isn't currently working with us!

Oops, thank you @jkim_wikimedia! @LeanneS Can you remind me why we don't want to send automatic thank you letters to donors entered by Engage?

/me skulks back to FR-tech moon cave...

@Ejegg For the Engage import, I believe it defaults to send one. For the donations they enter by hand, we don't always want an automatic TY email because they enter matching gifts and donor advised funds, etc., which don't need the tax-exempt statement and have different TYs.

Change 457697 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] '0' or blank no_thank_you means send email

https://gerrit.wikimedia.org/r/457697

Change 457697 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] '0' or blank no_thank_you means send email

https://gerrit.wikimedia.org/r/457697

@LeanneS and @jkim_wikimedia : This is all deployed. Now '0' or a blank string in the no_thank_you field are accepted as meaning 'yes, do send a thank you email'. New donations entered via the UI will get a default value of 'Manually entered' in that field. If you are entering donations via the UI and WANT the thank-you mailer to send an email, you can just backspace that default value.

Hey @Ejegg - I just imported last month's donations and used the no_thank_you field with '0', but it's not showing up as an email being sent under contributions or activities. Did I do something wrong? Thanks!

@Ejegg Is this resolved?

Sorry @jkim_wikimedia, I just saw your message now. I'll take a look at those donations and the logs of the TY mail sender from the same time.

Thanks @Ejegg ! Also, I just did my monthly import and the direct mail appeal also did not work... The template was the exact same as last month's, but for some reason the appeal information did not get into Civi.

OK, I just figured out the issue with the TY letters - I just had to add a mapping for a column with header 'No Thank You' to the logic. I'll let you know when that's deployed. I didn't see any column mapping for 'Direct Mail Appeal' either, but that's simple to add.

Change 463169 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] Add 'No Thank You' and 'Direct Mail Appeal' Stripe mappings

https://gerrit.wikimedia.org/r/463169

Great, thanks @Ejegg !!

Change 463169 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Add missing Stripe import mappings

https://gerrit.wikimedia.org/r/463169

OK @jkim_wikimedia, the Stripe import should now take all the same custom columns as check and Benevity imports, including 'No Thank You' and 'Direct Mail Appeal'.