Page MenuHomePhabricator
Create Task
Maniphest T202101

[Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing
Closed, ResolvedPublic
Actions

Description

Icons for Page Settings and Find and replace are missing.

Screen Shot 2018-08-16 at 2.49.23 PM.png (498×1 px, 115 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI)mediawiki/extensions/VisualEditormaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Aug 16 2018, 9:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 16 2018, 9:53 PM
Jdforrester-WMF assigned this task to Esanders.Aug 16 2018, 9:54 PM
Jdforrester-WMF edited projects, added VisualEditor (Current work), VisualEditor-MediaWiki; removed VisualEditor, OOUI.
Jdforrester-WMF subscribed.

Being fixed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/453269

Ryasmeen renamed this task from Icons for "Page Settings" and "Find and replace" are missing to [Regression pre-wmf.18] Icons for "Page Settings" and "Find and replace" are missing.Aug 16 2018, 9:59 PM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.Aug 16 2018, 11:24 PM
Jdforrester-WMF added a project: MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)).
Volker_E mentioned this in T190581: Clarify 'settings' and 'advanced' icon names.Aug 16 2018, 11:34 PM
• Deskana triaged this task as Medium priority.Aug 17 2018, 9:28 AM
Peachey88 added a project: Regression.Aug 17 2018, 10:27 AM
Ryasmeen added a comment.Aug 20 2018, 7:13 PM

@Esanders: The icons are back now on the drop down but the Page Settings icon is still missing inside the Options dialog.

Screen Shot 2018-08-20 at 2.11.33 PM.png (445×704 px, 61 KB)

gerritbot subscribed.Aug 20 2018, 10:27 PM

Change 454165 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI)

https://gerrit.wikimedia.org/r/454165

gerritbot added a project: Patch-For-Review.Aug 20 2018, 10:27 PM
matmarex subscribed.Aug 20 2018, 10:31 PM

For future reference, these two patches that weren't mentioned here yet also were fixing the icons:

gerritbot added a comment.Aug 20 2018, 10:55 PM

Change 454165 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] ve.ui.MWSettingsPage: Fix missing icon (renamed in OOUI)

https://gerrit.wikimedia.org/r/454165

matmarex added a comment.Aug 20 2018, 11:18 PM

@Ryasmeen Thanks, that should be fixed as well now.

Ryasmeen added a project: Verified.Aug 21 2018, 1:42 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• Deskana closed this task as Resolved.Aug 21 2018, 9:46 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 21 2018, 9:46 AM
• Whatamidoing-WMF mentioned this in T202758: Find-and-replace icon is missing in the 2010 WikiEditor.Aug 24 2018, 5:13 PM
Schnark mentioned this in T202805: Improve process of deprecating icons in OOUI.Aug 25 2018, 9:33 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits