Page MenuHomePhabricator

Update Ace Editor library to a more recent version
Open, Needs TriagePublic

Description

The ace editor library hasn't been updated for more than one year. Many important changes were made.

Event Timeline

Eugene created this task.Aug 17 2018, 8:32 AM

Where to see / find "the ace editor library"? What makes you think that it has not been updated for two years? Links please.

Please follow https://mediawiki.org/wiki/How_to_report_a_bug and provide enough information when creating tasks.

@Aklapper The last update of ace editor library was on https://github.com/wikimedia/mediawiki-extensions-CodeEditor/commit/628e0a84abdb8acfdaf8ae6202abcd75ec335ec2 as far as I can see in commits log of CodeEditor

Eugene updated the task description. (Show Details)Aug 17 2018, 9:16 AM

If "Many important changes were made" please explain what that means or at least provide a reference. Again: https://mediawiki.org/wiki/How_to_report_a_bug

What are the important changes that you identified?

handle escaped quotes, improve highlight rules, fix typescript declarations and many others

Change 453402 had a related patch set uploaded (by Aklapper; owner: Gvozdet):
[mediawiki/extensions/CodeEditor@master] Update to ace v1.4.1

https://gerrit.wikimedia.org/r/453402

How https://gerrit.wikimedia.org/r/453402 can be merged to master? Who can do it?