Page MenuHomePhabricator
Create Task
Maniphest T202142

Create a Constant in Mediawiki for the name of the 'main' slot for MCR
Closed, ResolvedPublic
Actions

Description

As discussed in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/+/450069/15/lib/includes/Store/EntityNamespaceLookup.php

rather than using 'main' everywhere instead we should use a constant, and that constant should be defined in core somewhere.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add constant for the name of the 'main' slot for MCRmediawiki/coremaster+339 -305
Customize query in gerrit

Event Timeline

Addshore created this task.Aug 17 2018, 2:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2018, 2:49 PM
Addshore added a project: User-Addshore.Aug 17 2018, 2:49 PM
Addshore moved this task from Unsorted 💣 to Watching 👀 on the User-Addshore board.
Addshore added a project: Technical-Debt.
gerritbot subscribed.Sep 24 2018, 10:47 PM

Change 462588 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/core@master] Add constant for the name of the 'main' slot for MCR

https://gerrit.wikimedia.org/r/462588

gerritbot added a project: Patch-For-Review.Sep 24 2018, 10:47 PM
Tgr subscribed.Sep 24 2018, 10:47 PM

Not sure about the value of this, but it was easy to do, so...

gerritbot added a comment.Sep 26 2018, 11:55 AM

Change 462588 merged by jenkins-bot:
[mediawiki/core@master] Add constant for the name of the 'main' slot for MCR

https://gerrit.wikimedia.org/r/462588

Jdforrester-WMF closed this task as Resolved.Sep 26 2018, 3:40 PM
Jdforrester-WMF assigned this task to Tgr.
Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)); removed Patch-For-Review.
• CCicalese_WMF moved this task from Inbox to Done on the Multi-Content-Revisions board.Oct 1 2018, 12:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits