Page MenuHomePhabricator
Create Task
Maniphest T202154

Audit modules 2018: Reduce registry overhead
Closed, ResolvedPublic
Actions

Description

T159911: Audit modules (2017) | T219342: Pageview performance timeline analysis (March 2019)

📘 See also Wikipedia's JavaScript initialisation on a budget on our blog.

Follows-up on last year's T159911. This year, specifically focussing on:

  • deprecating and/or removing unused/unmaintained modules.
  • reducing overhead on startup registry where possible.

See also "Size of scripts" at https://www.mediawiki.org/wiki/Wikimedia_Performance_Team/Page_load_performance.

Overview

Startup response size breakdown
@Catrope and @Krinkle wrote for T192623 (as of 7 May 2018)

Network transfer: 29 K
Uncompressed content-length: 85,299

Breakdown:

  • mwPerf + mwNow + isCompatible + nojs/NORLQ handling + startUp.addSource: 1,195 bytes (1.4%)
  • startUp.register: 67,999 bytes (80%)
    • jquery.*: 3013 bytes
    • mediawiki.*: 8532 bytes (core modules)
      • mediawiki.widgets.*: 1042 bytes
    • oojs*: 1073 bytes
    • skins.*: 344 bytes
    • schema.*: 2464 bytes
    • ext.*: 51,857 bytes (Extension modules)
      • CentralNotice: 1125 bytes
      • VE+Citoid: 2912 bytes
      • mobile.* + Minerva: 3588 bytes
      • Echo+Thanks: 862 bytes
      • RelatedArticles+RevisionSlider+TwoColConflict: 1786 bytes
      • ULS: 912 bytes
      • ContentTranslation (CX): 6573 bytes T203695
      • Wikibase: 14,007 bytes T203696
      • Gadgets: 4956 bytes
      • TMH/mwEmbed: 1426 bytes
  • startUp.config: 15,537 bytes (18%)
  • RLQ handling + addScript: 485 (0.6%)

Details

Show related patches Customize query in gerrit

Revisions and Commits

rMW MediaWiki
rMWecc812f06e7d mediawiki.api: Merge modules into one
rMWe61f2628beff mediawiki.debug: Move internal footHovzer to the same module
rMWf1d815f528e9 Remove deprecated 'json' module
rMW20a0be5ed552 Remove deprecated 'dom-level2-shim' module
rMW5bf64e7f7231 Remove the unused 'jquery.farbtastic' module
rMWb07b326476ef mediawiki.special.watchlist: Combine visitedstatus module
rMW15eac4c27939 mediawiki.special: Combine various tiny specialpage style modules
rECTX extension-ContentTranslation
rECTXa9e11de73d51 Reduce the number of JavaScript globals defined on all pages
rEUWI extension-UploadWizard
rEUWI1b9ff2f90847 Merge most of UploadWizard's modules into one

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Krinkle updated the task description. (Show Details)Jan 10 2019, 11:23 PM
Krinkle updated the task description. (Show Details)Jan 18 2019, 6:20 AM
Krinkle added a commit: rMWecc812f06e7d: mediawiki.api: Merge modules into one.Jan 18 2019, 6:31 AM
gerritbot added a comment.Jan 18 2019, 6:31 AM

Change 485146 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.api: Remove deprecated module aliases

https://gerrit.wikimedia.org/r/485146

gerritbot added a project: Patch-For-Review.Jan 18 2019, 6:31 AM
gerritbot added a comment.Jan 18 2019, 6:36 AM

Change 434738 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Translate@master] Avoid deprecated mediawiki.api aliases on MW 1.32+

https://gerrit.wikimedia.org/r/434738

Krinkle updated the task description. (Show Details)Jan 19 2019, 2:22 AM
gerritbot added a comment.Jan 19 2019, 2:24 AM

Change 485355 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikiEditor@master] Remove deprecated ext.wikiEditor module aliases

https://gerrit.wikimedia.org/r/485355

gerritbot added a comment.Jan 19 2019, 2:56 AM

Change 485357 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] Remove deprecated module alias "jquery.byteLimit"

https://gerrit.wikimedia.org/r/485357

Krinkle updated the task description. (Show Details)Jan 20 2019, 1:34 AM
gerritbot added a comment.Jan 20 2019, 1:40 AM

Change 485481 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/MassMessage@master] Replace use of deprecated module alias 'jquery.byteLimit'

https://gerrit.wikimedia.org/r/485481

gerritbot added a comment.Jan 20 2019, 1:49 AM

Change 434738 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Avoid deprecated mediawiki.api aliases on MW 1.32+

https://gerrit.wikimedia.org/r/434738

gerritbot added a comment.Jan 20 2019, 11:06 AM

Change 485481 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Replace use of deprecated module alias 'jquery.byteLimit'

https://gerrit.wikimedia.org/r/485481

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 20 2019, 12:01 PM
Krinkle added a comment.EditedJan 21 2019, 10:10 PM
In T202154#4893971, @gerritbot wrote:

Change 485355 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikiEditor@master] Remove deprecated ext.wikiEditor module aliases

https://gerrit.wikimedia.org/r/485355

tourbot.log

ext.wikiEditor.dialogs

  • mwgrep: 0 results
  • mwgrep--user: 2 results (fixed)

ext.wikiEditor.core

  • mwgrep: 0 results
  • mwgrep--user: 0 results

jquery.wikiEditor.toolbar.i18n

  • mwgrep: 0 results
  • mwgrep--user: 7 results (fixed)

jquery.wikiEditor.dialogs.config

  • mwgrep: 1 result (fixed)
  • mwgrep--user: 0 results

jquery.wikiEditor.dialogs

  • mwgrep: 0 results
  • mwgrep--user: 0 results

jquery.wikiEditor.core

  • mwgrep: 0 results
  • mwgrep--user: 0 results

jquery.wikiEditor

  • mwgrep: 9 results (fixed, skipped 3)
  • mwgrep--user: 31 results (fixed, skipped 9)

ext.wikiEditor.toolbar

  • mwgrep: 212 results (fixed, skipped 10)
  • mwgrep-definition: 14 results (fixed)
  • mwgrep--user: 567 results (fixed, skipped 32)
Krinkle updated the task description. (Show Details)Jan 22 2019, 8:32 PM
gerritbot added a comment.Jan 22 2019, 9:56 PM

Change 485146 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.api: Remove deprecated module aliases

https://gerrit.wikimedia.org/r/485146

gerritbot added a comment.Jan 22 2019, 9:57 PM

Change 485357 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated module alias "jquery.byteLimit"

https://gerrit.wikimedia.org/r/485357

gerritbot added a comment.Jan 22 2019, 9:57 PM

Change 485355 merged by jenkins-bot:
[mediawiki/extensions/WikiEditor@master] Remove deprecated ext.wikiEditor module aliases

https://gerrit.wikimedia.org/r/485355

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.16; 2019-02-05); removed MW-1.33-notes (1.33.0-wmf.14; 2019-01-22).Jan 22 2019, 10:01 PM
Krinkle updated the task description. (Show Details)Jan 22 2019, 10:05 PM
Jdforrester-WMF removed a project: Patch-For-Review.Jan 22 2019, 10:09 PM
Krinkle moved this task from To-do: Goals prioritized current Quarter to Blocked (old) on the Performance-Team board.Jan 23 2019, 12:30 AM
Krinkle updated the task description. (Show Details)Jan 23 2019, 6:39 AM
Krinkle updated the task description. (Show Details)Jan 23 2019, 6:50 AM
Krinkle added a comment.Jan 23 2019, 6:55 AM

We achieved quite a lot in two quarters with the thematic focus on reducing the registry footprint (blogpost to follow).

Given I kept adding to the list (sorry), it was kind of expected we couldn't complete them all. The below few remain recommendations in our radar, but we'll close the task without them. I consider it in part a failure on our part because we compiled the list without consulting with the affected teams and which quarter to schedule for it. This'll be a learning point for the next thematic focus so that we know what we can expect and could collaborate on, and when.

Task description:

I've moved these tasks to the radar as standing "Perf recommendation" to pick from at any time. We're always happy to help when the time comes. Meanwhile, our primary attention and thematic focus for the quarter will move onwards to another area. (TBD)

Krinkle updated the task description. (Show Details)Jan 23 2019, 6:56 AM
Krinkle added a commit: rECTXa9e11de73d51: Reduce the number of JavaScript globals defined on all pages.Jan 27 2019, 9:33 PM
Krinkle updated the task description. (Show Details)Jan 29 2019, 7:41 PM
Krinkle raised the priority of this task from Medium to High.Feb 5 2019, 10:39 PM

Current (well, technically previous) quarter goal. Raising priority to reflect this so I won't forget.

gerritbot added a comment.Feb 7 2019, 10:44 PM

Change 461247 had a related patch set uploaded (by Krinkle; owner: Catrope):
[mediawiki/core@master] resourceloader: Remove mediawiki.ForeignStructuredUpload.config module

https://gerrit.wikimedia.org/r/461247

gerritbot added a project: Patch-For-Review.Feb 7 2019, 10:44 PM

Change 461247 abandoned by Krinkle:
resourceloader: Remove mediawiki.ForeignStructuredUpload.config module

Reason:
Looks like this has since been squashed into I203d4e3ecdeeeb16729eba2dcf40d11a4.

https://gerrit.wikimedia.org/r/461247

Krinkle mentioned this in T215943: ExternalGuidance: Reduce number of registered modules.Feb 12 2019, 6:45 PM
jeblad mentioned this in T216313: Console warning "jquery.localize is missing" when loading VisualEditor on no.wikipedia.org.Feb 16 2019, 9:02 AM
Krinkle removed projects: Patch-For-Review, MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Feb 18 2019, 10:32 PM

Closing as the quarter has ended last month. T203696 and T203695 will continue for a bit on their own. Thanks everyone!

Krinkle closed this task as Resolved.Feb 18 2019, 10:34 PM
Krinkle moved this task from Blocked (old) to Doing (old) on the Performance-Team board.
Krinkle added a project: Wikimedia-Performance-publish.
Krinkle moved this task from Untriaged to Published on the Wikimedia-Performance-publish board.
Krinkle mentioned this in T216646: Reduce startup registry footprint of WikibaseMediaInfo.Feb 20 2019, 7:07 PM
gerritbot added a comment.Mar 3 2019, 1:26 AM

Change 493997 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resources: Remove 'jquery.xmldom' module

https://gerrit.wikimedia.org/r/493997

gerritbot added a project: Patch-For-Review.Mar 3 2019, 1:26 AM
gerritbot added a comment.Mar 3 2019, 1:44 AM

Change 493997 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resources: Remove 'jquery.xmldom' module

https://gerrit.wikimedia.org/r/493997

gerritbot added a comment.Mar 3 2019, 1:44 AM

Change 494003 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resources: Remove 'jquery.mockjax' module

https://gerrit.wikimedia.org/r/494003

gerritbot added a comment.Mar 3 2019, 1:54 AM

Change 494004 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resources: Remove deprecated 'jquery.hidpi' module

https://gerrit.wikimedia.org/r/494004

gerritbot added a comment.Mar 3 2019, 4:15 AM

Change 493997 merged by jenkins-bot:
[mediawiki/core@master] resources: Remove 'jquery.xmldom' module

https://gerrit.wikimedia.org/r/493997

gerritbot added a comment.Mar 3 2019, 6:18 PM

Change 494003 merged by jenkins-bot:
[mediawiki/core@master] resources: Remove 'jquery.mockjax' module

https://gerrit.wikimedia.org/r/494003

gerritbot added a comment.Mar 5 2019, 12:14 PM

Change 494004 merged by jenkins-bot:
[mediawiki/core@master] resources: Remove deprecated 'jquery.hidpi' module

https://gerrit.wikimedia.org/r/494004

Krinkle removed a project: Patch-For-Review.Mar 5 2019, 2:43 PM
Krinkle updated the task description. (Show Details)
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Mar 5 2019, 3:01 PM
Esanders mentioned this in T107283: Use lib/ve/build/modules.json to build extension.json.Mar 5 2019, 7:42 PM
Krinkle mentioned this in T209699: Deprecate then remove jquery.async module.Mar 6 2019, 12:02 AM
Krinkle closed subtask T216646: Reduce startup registry footprint of WikibaseMediaInfo as Resolved.Mar 8 2019, 12:16 AM
Krinkle updated the task description. (Show Details)Mar 8 2019, 12:23 AM
Krinkle moved this task from Published to Ready for write-up on the Wikimedia-Performance-publish board.Mar 14 2019, 12:55 AM
Krinkle updated the task description. (Show Details)Apr 24 2019, 6:50 PM
Krinkle updated the task description. (Show Details)
Krinkle mentioned this in T219342: Pageview performance timeline analysis (March 2019).
Krinkle mentioned this in T221805: Reduce module registration overhead from CentralNotice.Apr 24 2019, 8:25 PM
Pginer-WMF closed subtask T203695: Drastically reduce the number of ResourceLoader modules that CX creates as Resolved.May 7 2019, 8:27 AM
Krinkle updated the task description. (Show Details)May 29 2019, 7:11 PM
Krinkle mentioned this in T225842: Allow ResourceLoader modules to be "private", bundle them with their dependent modules.Jun 14 2019, 5:45 PM
Ladsgroup awarded a token.Jul 13 2019, 3:35 PM
gerritbot added a comment.Aug 4 2019, 11:43 PM

Change 527945 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Kartographer@master] Merge ext.kartographer.settings to the its parent

https://gerrit.wikimedia.org/r/527945

gerritbot added a project: Patch-For-Review.Aug 4 2019, 11:43 PM
Ladsgroup mentioned this in T229791: TwoColConflict and RevisionSlider resourceloader modules can be packed into one or two modules to save load time..Aug 5 2019, 9:49 AM
gerritbot added a comment.Aug 5 2019, 1:40 PM

Change 527945 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Merge ext.kartographer.settings to the its parent

https://gerrit.wikimedia.org/r/527945

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 5 2019, 2:00 PM
gerritbot added a comment.Aug 5 2019, 2:46 PM

Change 528165 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/WikimediaMaintenance@master] Create blameStartupRegistry.php script

https://gerrit.wikimedia.org/r/528165

Krinkle added a comment.Aug 5 2019, 2:49 PM
This comment was removed by Krinkle.
gerritbot added a comment.Aug 5 2019, 3:08 PM

Change 528171 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/Thanks@master] Merge jquery.findWithParent.js into 'ext.thanks.flowthank'

https://gerrit.wikimedia.org/r/528171

gerritbot added a comment.Aug 5 2019, 3:33 PM

Change 528171 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Merge jquery.findWithParent.js into 'ext.thanks.flowthank'

https://gerrit.wikimedia.org/r/528171

Krinkle mentioned this in T229836: Track module registry size over time.Aug 5 2019, 3:43 PM
ReleaseTaggerBot edited projects, added MW-1.34-notes (1.34.0-wmf.19; 2019-08-20); removed MW-1.34-notes (1.34.0-wmf.17; 2019-08-06).Aug 6 2019, 6:01 PM
Krinkle mentioned this in T121730: Audit use of @embed and remove where not needed (2019).Aug 6 2019, 7:12 PM
Krinkle mentioned this in T159911: Audit modules (2017).
• alaa_wmde closed subtask T203696: Drastically reduce the number of ResourceLoader modules that WikibaseClient registers as Resolved.Aug 12 2019, 2:28 PM
Krinkle mentioned this in T232688: Remove jquery.checkboxShiftClick from default payload.Sep 11 2019, 10:46 PM
Krinkle mentioned this in Blog Post: Wikipedia's JavaScript initialisation on a budget.Sep 17 2019, 8:03 PM
Krinkle mentioned this in T233675: Audit startup JavaScript payload (Aug 2018—Sept 2019).Sep 24 2019, 3:37 AM
Krinkle removed projects: Patch-For-Review, MW-1.33-notes (1.33.0-wmf.21; 2019-03-12).Oct 4 2019, 7:49 PM
Krinkle updated the task description. (Show Details)
Krinkle mentioned this in T111542: Update jquery.hidpi.js to support width/height specs.Oct 15 2019, 1:10 AM
Krinkle mentioned this in T235944: Reduce number of modules registered by MassMessage.Oct 19 2019, 8:23 PM
DannyS712 updated the task description. (Show Details)Oct 27 2019, 5:02 PM
Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptOct 27 2019, 5:02 PM
Krinkle moved this task from Ready for write-up to Published on the Wikimedia-Performance-publish board.Mar 2 2020, 9:40 PM
Krinkle mentioned this in T280746: Reduce number of distinct module bundles registered by TimedMediaHandler.Apr 21 2021, 3:05 AM
kostajh mentioned this in T321351: [EPIC] Add CSS-only components.Jan 11 2023, 9:54 AM
MusikAnimal mentioned this in T345414: Enabling Phonos on all projects increased JavaScript and CSS size, Phonos should not use OOUI on page load.Sep 14 2023, 6:14 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL