Page MenuHomePhabricator

Should AbuseFilter identify change tags by id (and not name)?
Open, Needs TriagePublic

Description

Currently, change tag schema in core is being normalised (T185355), so that change tags are identified by a number, not name. Should AbuseFilter improve its schema as well?

The relevant fields are afa_parameters for rows with afa_consequence = 'tag' in abuse_filter_action and afh_actions in abuse_filter_history.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 18 2018, 2:48 PM

It'd be good, and should be done as part of the major overhaul of change tags mentioned in several tasks across the workboard.

Huji added a subscriber: Huji.Aug 18 2018, 5:28 PM

I think it is a great idea too. We should maintain backward compatibility though, and whenever an old filter is updated, we should replace its references to the new format.

We could also decide whether creating a maintenance script that updates all filters and logs would be appropriate or not. It is best that we list all the places in which something needs to be changed, and assess the overall work.

Daimona moved this task from Backlog to Change tags on the AbuseFilter board.Aug 26 2018, 2:09 PM