Page MenuHomePhabricator

Mp4 on Commons - since when did we allow it
Closed, ResolvedPublic

Description

https://commons.wikimedia.org/w/index.php?title=Commons:Administrators%27_noticeboard&oldid=315246440#MP4_--_since_when_did_we_allow_it

Probably a bug. I've noticed other wikis also accepting .mp4, I have no way to check but I doubt they always have. Also enwiki, it didn't have any mp4 files yet but it does now: https://en.wikipedia.org/wiki/File:Yermi.mp4.

Event Timeline

It seems like this is a recent change too since the timestamps on the uploads say that this started July 31, 2018.

Co-incided with conversion to extension registration? Possible Regression

Change 453878 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix regression: double-reg of file types and incorrect 'mp4'

https://gerrit.wikimedia.org/r/453878

Yep, that's a regression in the extension.json migration. The addition of file types to $wgFileExtensions was being done twice, both in the extension.json and then again dynamically, causing the way that 'mp4' was removed from the list to fail because it only removed one instance of it.

Scheduling the fix to go out tomorrow morning pacific.

Change 453879 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.32.0-wmf.16] Fix regression: double-reg of file types and incorrect 'mp4'

https://gerrit.wikimedia.org/r/453879

Change 453878 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix regression: double-reg of file types and incorrect 'mp4'

https://gerrit.wikimedia.org/r/453878

Change 453879 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.32.0-wmf.16] Fix regression: double-reg of file types and incorrect 'mp4'

https://gerrit.wikimedia.org/r/453879

Fix has been deployed; no more MP4 files should be coming in.

Should we leave open for the community to delete?

Should we leave open for the community to delete?

I'll do a batch run through them later today/tonight, then close out the task.

@brion Perhaps they should be left up for a while. They seem to trigger strange bugs. For example https://commons.wikimedia.org/wiki/File:Maalwerk_Volmolen_Frankenhof.mp4 which is a video that was shot in portrait mode, gets completely messed up when wiki makes vp9 out of it.

Should I file bug reports for such glitches or not as uploading mp4 should have never been possible in the first place?

Update: reported as T209560

@brion Perhaps they should be left up for a while. They seem to trigger strange bugs. For example https://commons.wikimedia.org/wiki/File:Maalwerk_Volmolen_Frankenhof.mp4 which is a video that was shot in portrait mode, gets completely messed up when wiki makes vp9 out of it.

Should I file bug reports for such glitches or not as uploading mp4 should have never been possible in the first place?

Yeah, file bug(s) please as appropriate.

TMH can/does/will support MP4, but just because Commons isn't allowing it, doesn't mean it's not a valid bug in one form or another, and therefore other users of TMH may benefit :)

These files are still up btw...

@TheDJ I plan to convert some more after T209557 is fixed..

All cleaned up now it seems.