Page MenuHomePhabricator

Empty strings in Chinese
Closed, ResolvedPublic

Description

Firefox_Screenshot_2018-08-19T06-17-45.192Z.png (1,009×643 px, 260 KB)

As the screenshot shows,it seems missing some texts or icons,in chinese wikipedia.

Event Timeline

Framawiki renamed this task from Bug report:Missing something for other languages to Empty strings in Chinese.Aug 19 2018, 8:24 AM
Framawiki subscribed.

Hi @Ed29, thanks for taking the time to report this! Unfortunately this report lacks some information. If you have time and can still reproduce the problem: Please add a more complete description to this report by providing a clear list of specific steps to reproduce the situation, as little details sometimes matter, so that nobody needs to guess how you performed each step, and by describing actual results and by describing expected results after performing the steps to reproduce, plus information about your web browser(s) tested.

You can edit the task description by clicking Edit Task. Thanks!

I can reproduce this bug in the main page of the wiki https://zh.wikipedia.org/?useskin=timeless&uselang=qqx using my browser adaptive view functionality.

After a quick investigation it looks like that Chinese wiki has a special functionality that allow the user to choose what language version he wants (like Chinese simplified). There are links in the top dropdown for that under the name "不转换" (see vector view https://zh.wikipedia.org/). It looks like it's these links that aren't correctly shown in Timeless.

I suspect https://www.mediawiki.org/wiki/Extension:CLDR to be the extension that adds these links.

Sounds more like LanguageConverter (which is core feature)

It's the language variants, whatever it is.

Not that it really matters what it is; we just need a better default handling in general.

Okay, anyone know how I replicate this on my dev environment?

Change 460419 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Don't hide labels for mobile cactions that have no icon

https://gerrit.wikimedia.org/r/460419

This patch should at least resolve the immediate issue, but I'd still like a better, more collapsed handling for these variants specifically, so the above question holds.

Change 460419 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Don't hide labels for mobile cactions that have no icon

https://gerrit.wikimedia.org/r/460419

Isarra claimed this task.