Run the following script:
from pywikibot import * from time import * s = Site('en', 'wikipedia') print(s.server_time()) sleep(2) print(s.server_time()) sleep(2) print(s.server_time())
Result:
2018-08-18T11:23:28Z 2018-08-19T11:03:03Z 2018-08-19T11:03:06Z
Second and third timestamps make sense, but the first one should only be a few seconds earlier. It seems that the cached result is being returned for the first call by mistake.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| pywikibot.site.Siteinfo: Fix the bug in cache_time when loading a CachedRequest | pywikibot/core | master | +48 -27 |
I think the root cause of the issue is that sometimes the general SiteInfo is loaded using a CachedRequest from a cache file, but gets a new timestamp.
We should change Siteinfo class to make it not update timestamps when loading from a CachedRequest or update it with a correct timestamp. Therefore, we may need to change CachedRequest and related calls somehow to return the the cache time to SiteInfo.
Change 453944 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] Cleanup the code in site.SiteInfo
Change 453944 merged by jenkins-bot:
[pywikibot/core@master] pywikibot.site.Siteinfo: Fix the bug in cache_time when loading a CachedRequest