Page MenuHomePhabricator
Create Task
Maniphest T202300

RESTBase passes through the user-agent
Closed, DeclinedPublic
Actions

Description

It seems like currently, RESTBase passes through the User-Agent header while making internal requests, so, for example, Mediawiki API reports requests from RESTBase, but initiated by ChangeProp as Change-Propagation (WMF). I'm not sure if this is desired behavior, but it's confusing.

It might be useful to know what user-agent originated the chain of requests, but that should be done either by matching the request-id, or by providing a new header, like X-Client-User-Agent or X-Api-User-Agent, but RESTBase should reset the user-agent to itself when making internal requests.

Event Timeline

• Pchelolo created this task.Aug 20 2018, 3:33 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2018, 3:33 PM
• mobrovac added a project: Platform Team Legacy (Later).Oct 15 2018, 2:14 PM
CCicalese_WMF added a project: Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)).Oct 16 2018, 2:52 PM
• Clarakosi added a project: User-Clarakosi.Nov 8 2018, 6:15 PM
WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 3:45 PM
WDoranWMF removed a project: Platform Team Legacy (Later).
WDoranWMF triaged this task as Low priority.Sep 3 2019, 6:45 PM
WDoranWMF edited projects, added Platform Engineering; removed Platform Engineering (Needs Cleaning - Security, stability, performance, and scalability (TEC1)), Services (later).
WDoranWMF moved this task from Inbox to Services Tech Debt on the Platform Engineering board.
Anomie subscribed.Sep 3 2019, 6:45 PM

Api-User-Agent already exists as a header, augmenting User-Agent for XHR requests from browsers where the agent can't be changed.

Possibly Restbase should directly augment the user agent rather than either replacing it or passing it through unchanged.

• Pchelolo closed this task as Declined.Nov 22 2019, 5:58 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL