Page MenuHomePhabricator
Create Task
Maniphest T202320

Remove StopForumSpam/updateBlacklist.php in favour of maintenance/updateBlacklist.php
Closed, ResolvedPublic
Actions

Description

updateBlacklist.php was moved in 3e7633e0bc11

Given that such file was renamed a while ago, maybe we should think about removing the file in the future, with a deprecation period beforehand.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove old entry pointsmediawiki/extensions/StopForumSpammaster+0 -23
Follow-up I5a9c23ce: Hard-deprecate `updateBlacklist.php`mediawiki/extensions/StopForumSpamREL1_32+1 -0
Follow-up I5a9c23ce: Hard-deprecate `updateBlacklist.php`mediawiki/extensions/StopForumSpammaster+1 -0
Soft-deprecate updateBlacklist.php filemediawiki/extensions/StopForumSpammaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

MarcoAurelio created this task.Aug 20 2018, 7:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2018, 7:53 PM
gerritbot subscribed.Aug 20 2018, 7:59 PM

Change 454086 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/StopForumSpam@master] Deprecate updateBlacklist.php file

https://gerrit.wikimedia.org/r/454086

gerritbot added a project: Patch-For-Review.Aug 20 2018, 7:59 PM
gerritbot added a comment.Aug 28 2018, 5:08 PM

Change 454086 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Soft-deprecate updateBlacklist.php file

https://gerrit.wikimedia.org/r/454086

Krinkle moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.Sep 19 2018, 7:07 PM
Krinkle renamed this task from Deprecate updateBlacklist.php in favor of maintenance/updateBlacklist.php to Remove StopForumSpam/updateBlacklist.php in favour of core's maintenance/updateBlacklist.php.Feb 8 2019, 9:36 PM
Krinkle edited projects, added Technical-Debt; removed Technical-Debt (Deprecation process).
Krinkle moved this task from Unsorted to Migrate / Replace on the Technical-Debt board.
gerritbot added a comment.Mar 30 2019, 8:10 PM

Change 500186 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/StopForumSpam@master] Follow-up I5a9c23ce: Hard-deprecated updateBlacklist.php

https://gerrit.wikimedia.org/r/500186

MarcoAurelio added a subscriber: Krinkle.Mar 30 2019, 8:20 PM

@Krinkle Patch for hard deprecation submitted above. Shall we move back to the Technical-Debt (Deprecation process) board?

Krinkle added a comment.Apr 1 2019, 4:07 PM

No, that board is for tracking the deprecation cycle of MediaWiki core and other WMF-maintained software. This task seems well-suited on StopForumSpam's own board, and in addition on the generic tech-debt workboard for any usage/referenced that may need to be updated.

Krinkle unsubscribed.Apr 1 2019, 4:08 PM
gerritbot added a comment.Apr 2 2019, 7:59 PM

Change 500186 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Follow-up I5a9c23ce: Hard-deprecate updateBlacklist.php

https://gerrit.wikimedia.org/r/500186

gerritbot added a comment.Apr 2 2019, 8:52 PM

Change 500836 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[mediawiki/extensions/StopForumSpam@REL1_32] Follow-up I5a9c23ce: Hard-deprecate updateBlacklist.php

https://gerrit.wikimedia.org/r/500836

MarcoAurelio added subscribers: Daimona, Legoktm.EditedApr 3 2019, 10:08 AM

@Legoktm @Daimona The REL1_32 cherry pick fails on Abusefilter and EquivSet in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/42856/console

Any ideas?

D'oh: all PHP tests for StopForumSpam looks broken on REL1_32 :-/

Daimona added a comment.Apr 3 2019, 10:10 AM

@MarcoAurelio Yes, it's T189560. You have to vote V+2.

MarcoAurelio added a comment.Apr 3 2019, 10:18 AM
In T202320#5081094, @Daimona wrote:

@MarcoAurelio Yes, it's T189560. You have to vote V+2.

I see it mentions 1.31. It's REL1.32 also affected?

Daimona added a comment.Apr 3 2019, 10:18 AM
In T202320#5081112, @MarcoAurelio wrote:
In T202320#5081094, @Daimona wrote:

@MarcoAurelio Yes, it's T189560. You have to vote V+2.

I see it mentions 1.31. It's REL1.32 also affected?

Yes, any REL* branch is.

MarcoAurelio added a comment.Apr 3 2019, 10:20 AM

Alright. Thank you. Given that it is my own change I'll let others to force-merge this if they like.

gerritbot added a comment.Apr 5 2019, 2:31 PM

Change 500836 merged by Umherirrender:
[mediawiki/extensions/StopForumSpam@REL1_32] Follow-up I5a9c23ce: Hard-deprecate updateBlacklist.php

https://gerrit.wikimedia.org/r/500836

Maintenance_bot removed a project: Patch-For-Review.May 22 2019, 2:42 PM
gerritbot added a comment.Jul 8 2019, 9:26 AM

Change 521229 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/StopForumSpam@master] Remove old entry points

https://gerrit.wikimedia.org/r/521229

gerritbot added a project: Patch-For-Review.Jul 8 2019, 9:26 AM
Reedy renamed this task from Remove StopForumSpam/updateBlacklist.php in favour of core's maintenance/updateBlacklist.php to Remove StopForumSpam/updateBlacklist.php in favour of maintenance/updateBlacklist.php.Jul 8 2019, 9:26 AM
gerritbot added a comment.Jul 10 2019, 12:52 AM

Change 521229 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Remove old entry points

https://gerrit.wikimedia.org/r/521229

Maintenance_bot removed a project: Patch-For-Review.Jul 10 2019, 1:10 AM
MarcoAurelio closed this task as Resolved.Jul 10 2019, 9:43 AM
MarcoAurelio assigned this task to Reedy.

Closing as they've been removed on master. If a port to any REL is needed, feel free to cherry-pick.

sbassett moved this task from Backlog to Done on the MediaWiki-extensions-StopForumSpam board.Jul 10 2020, 8:41 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits