Maniphest T202321

generateSitemaps output is not properly formatted
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Imarlier
	Aug 20 2018, 7:53 PM

Description

generateSitemaps.php outputs an XML "index" file, that provides relative links to the actual maps. The links need to be absolute.

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	sitemaps: absolute URL for sitemaps	mediawiki/core	master	+3 -1

Customize query in gerrit

Related Objects

Mentioned Here: T203113: generateSitemaps.php should use wfExpandUrl

Event Timeline

• Imarlier created this task.Aug 20 2018, 7:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2018, 7:53 PM

Krinkle added a project: MediaWiki-Maintenance-system.Aug 20 2018, 8:34 PM

Change 456190 had a related patch set uploaded (by Imarlier; owner: Imarlier):
[mediawiki/core@master] sitemaps: absolute URL for sitemaps

https://gerrit.wikimedia.org/r/456190

gerritbot added a project: Patch-For-Review.Aug 29 2018, 6:12 PM

• Imarlier claimed this task.Aug 29 2018, 6:30 PM

Change 456190 merged by jenkins-bot:
[mediawiki/core@master] sitemaps: absolute URL for sitemaps

https://gerrit.wikimedia.org/r/456190

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 29 2018, 9:00 PM

T203113 is a follow-on to this, to do some code cleanup.

• Imarlier triaged this task as Medium priority.Sep 17 2018, 7:16 PM

• Imarlier edited projects, added Performance-Team; removed Performance-Team (Radar).

• Imarlier moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.

Verified that generateSitemap.php is now outputting with fully qualified paths:

<?xml version="1.0" encoding="UTF-8"?>
<sitemapindex xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">
        <sitemap>
                <loc>https://it.wikipedia.org/sitemap-itwiki-NS_0-0.xml.gz</loc>
                <lastmod>2018-09-17T19:23:19Z</lastmod>
        </sitemap>
        <sitemap>
                <loc>https://it.wikipedia.org/sitemap-itwiki-NS_0-1.xml.gz</loc>
                <lastmod>2018-09-17T19:23:19Z</lastmod>
        </sitemap>
        <sitemap>
                <loc>https://it.wikipedia.org/sitemap-itwiki-NS_0-2.xml.gz</loc>
                <lastmod>2018-09-17T19:23:19Z</lastmod>
        </sitemap>

generateSitemaps output is not properly formattedClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

generateSitemaps output is not properly formatted
Closed, ResolvedPublic
Actions