Page MenuHomePhabricator

Visualdiff stuck on particular diff due to "null is not an object"-error
Closed, ResolvedPublic

Description

Link: https://en.wikipedia.org/w/index.php?title=&diff=prev&oldid=855780722&diffmode=visual

[Warning] jQuery.Deferred exception: null is not an object (evaluating 'this.listNode.connect') – "onSetup@https://en.wikipedia.org/w/load.php?debug=false&lang=en&modules=diffMatchPatch%2Cpapaparse%2Crangefix%2Cspark-md5%2CtreeDiffer%2Cuni…" – undefined (load.php, line 52)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

This is actually the fault of my template-generated ref list code, not the visual diff code :/

Change 460405 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Cite@master] Template reflist: Re-render when converting for preview (e.g. visual diff)

https://gerrit.wikimedia.org/r/460405

Change 460405 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Template reflist: Re-render when converting for preview (e.g. visual diff)

https://gerrit.wikimedia.org/r/460405

Deskana triaged this task as Medium priority.