Page MenuHomePhabricator
Create Task
Maniphest T202359

[Regression pre-wmf.18] Toolbar does not get activated after pressing return
Closed, ResolvedPublic
Actions

Description

  1. Insert a hieroglyph.
  2. Go to the next line after pressing return.

The toolbar does not get activated.

Screen Shot 2018-08-21 at 12.30.48 AM.png (471×1 px, 150 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (236effcd7)mediawiki/extensions/VisualEditormaster+5 -2
Use consistent method for finding nearest cursor offsetVisualEditor/VisualEditormaster+12 -11
Get rid of display:inline-block from outer tablemediawiki/extensions/wikihieromaster+0 -4
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Aug 21 2018, 6:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2018, 6:01 AM
Esanders moved this task from To Triage to Needs Discussion/Analysis on the VisualEditor board.Sep 5 2018, 4:41 PM
Esanders subscribed.

I'm assuming this isn't limited to this one extension...

JTannerWMF moved this task from Needs Discussion/Analysis to Up next on the VisualEditor board.Sep 5 2018, 4:56 PM
Esanders added a comment.Sep 5 2018, 5:46 PM

It appears to behave the same for all block node inserts (of which there are a few). For me the node is selected and highlighted after insertion, pressing enter just opens the hiero editor again (as expected) and the only way to get to a new paragraph is using the block slugs.

Can you provide more detailed reproduction steps?

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 5 2018, 5:49 PM
Ryasmeen added a comment.EditedSep 5 2018, 8:46 PM

@Edsanders:

For this specific behavior try with an empty document. Here are the steps that I followed:

  1. Open VE for an empty page.
  2. Go to Insert>Hieroglyph.
  3. Type something in the context menu and click on "Insert".
  4. Now place the cursor at the end of line
  5. Press return

At this point, the cursor goes to the next line but the toolbar does not get activated

Now, if you try with a non-empty page the behavior is slightly different but the cursoring is still buggy.
For a non empty document, you won't even be able to place the cursor at the end of line after step 3, it goes straight to the next line.

Let me know if this helps to reproduce this issue.

Also, I haven't been able to reproduce this issue for any other block nodes.

Esanders added a comment.EditedSep 6 2018, 1:42 PM

Now place the cursor at the end of line

There shouldn't be a place to put your cursor, as hiero is a block level element. If I click at the end of the line the cursor goes nowhere and the toolbar is greyed out, as expected.

Esanders added a comment.EditedSep 6 2018, 1:45 PM

I note that in FF this is different, and you can put your cursor there.

On a related note, if I click to the right of a SyntaxHighlight block, the cursor renders inside it, but doesn't response to keyboard inputs.

Esanders added a project: VisualEditor-ContentEditable.Sep 6 2018, 7:51 PM
Esanders added a subscriber: dchan.Sep 8 2018, 9:01 PM
Ryasmeen added a comment.Sep 19 2018, 12:06 AM
In T202359#4562841, @Esanders wrote:

Now place the cursor at the end of line

There shouldn't be a place to put your cursor, as hiero is a block level element. If I click at the end of the line the cursor goes nowhere and the toolbar is greyed out, as expected.

This just got nastier on Chrome Version 69.0.3497.100. Now when I click at the end of a Hiero blocknode it crashes the browser. On top of that, I wasn't able to recover my edit. Got the following error:

Error: Failed to restore auto-saved session: TypeError: Cannot read property 'end' of null
    at VeDmSurface.ve.dm.Surface.restoreChanges (load.php?debug=false&lang=en&modules=ext.CodeMirror.lib|ext.CodeMirror.mode.mediawiki|ext.citoid.visualEditor|ext.graph.visualEditor|ext.score.visualEditor|ext.visualEditor.core%2Cmwlink%2Cwelcome|ext.wikihiero.visualEditor|mediawiki.action.view.redirectPage|mediawiki.skinning.content.parsoid|mediawiki.widgets|mediawiki.widgets.DateInputWidget%2CMediaSearch%2CStashedFileWidget|oojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0cedek9:535)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.surfaceReady (<anonymous>:579:697)
    at VeInitMwDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.surfaceReady (<anonymous>:1154:664)
    at <anonymous>:136:501
ve.init.mw.ArticleTarget.surfaceReady @ VM31:579
ve.init.mw.DesktopArticleTarget.surfaceReady @ VM31:1154
(anonymous) @ VM31:136
setTimeout (async)
ve.init.mw.Target.addSurface @ VM31:136
ve.init.mw.DesktopArticleTarget.addSurface @ VM31:1141
(anonymous) @ VM31:135
setTimeout (async)
(anonymous) @ VM31:135
setTimeout (async)
ve.init.mw.Target.setupSurface @ VM31:135
ve.init.mw.Target.documentReady @ VM31:133
ve.init.mw.ArticleTarget.documentReady @ VM31:578
ve.init.mw.ArticleTarget.loadSuccess @ VM31:577
ve.init.mw.DesktopArticleTarget.loadSuccess @ VM31:1144
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
jQuery.Deferred @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:190
then @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
(anonymous) @ VM30:16
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
jQuery.Deferred @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:190
then @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
OO.ui.Window.teardown @ VM30:26
(anonymous) @ VM30:16
setTimeout (async)
(anonymous) @ VM30:16
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
jQuery.Deferred @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:190
then @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
OO.ui.Window.hold @ VM30:26
(anonymous) @ VM30:16
setTimeout (async)
(anonymous) @ VM30:16
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
always @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
OO.ui.WindowManager.closeWindow @ VM30:16
OO.ui.Window.close @ VM30:25
(anonymous) @ VM30:31
(anonymous) @ VM30:7
OO.ui.Process.execute @ VM30:7
OO.ui.Dialog.executeAction @ VM30:30
OO.ui.Dialog.onActionClick @ VM30:27
oo.EventEmitter.emit @ VM21:162
oo.EventEmitter.emit @ VM21:162
OO.ui.mixin.ButtonElement.onClick @ load.php?debug=false&lang=en&modules=oojs-ui-core|oojs-ui-core.styles&skin=vector&version=06om5lh:26
dispatch @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:107
elemData.handle @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:103
Ryasmeen added a comment.EditedSep 24 2018, 10:21 PM

I was blaming the latest Chrome for this crashing issue (since it started crashing after I updated my Chrome), but I just checked this on BrowserStack, couldn't reproduce it on the same page with same OS, browser. So I'm confused now :/ Can someone else try to reproduce this on Chrome 69?

In T202359#4596436, @Ryasmeen wrote:
In T202359#4562841, @Esanders wrote:

Now place the cursor at the end of line

There shouldn't be a place to put your cursor, as hiero is a block level element. If I click at the end of the line the cursor goes nowhere and the toolbar is greyed out, as expected.

This just got nastier on Chrome Version 69.0.3497.100. Now when I click at the end of a Hiero blocknode it crashes the browser. On top of that, I wasn't able to recover my edit. Got the following error:

Error: Failed to restore auto-saved session: TypeError: Cannot read property 'end' of null
    at VeDmSurface.ve.dm.Surface.restoreChanges (load.php?debug=false&lang=en&modules=ext.CodeMirror.lib|ext.CodeMirror.mode.mediawiki|ext.citoid.visualEditor|ext.graph.visualEditor|ext.score.visualEditor|ext.visualEditor.core%2Cmwlink%2Cwelcome|ext.wikihiero.visualEditor|mediawiki.action.view.redirectPage|mediawiki.skinning.content.parsoid|mediawiki.widgets|mediawiki.widgets.DateInputWidget%2CMediaSearch%2CStashedFileWidget|oojs-ui-widgets|oojs-ui.styles.icons-editing-advanced&skin=vector&version=0cedek9:535)
    at VeInitMwDesktopArticleTarget.ve.init.mw.ArticleTarget.surfaceReady (<anonymous>:579:697)
    at VeInitMwDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.surfaceReady (<anonymous>:1154:664)
    at <anonymous>:136:501
ve.init.mw.ArticleTarget.surfaceReady @ VM31:579
ve.init.mw.DesktopArticleTarget.surfaceReady @ VM31:1154
(anonymous) @ VM31:136
setTimeout (async)
ve.init.mw.Target.addSurface @ VM31:136
ve.init.mw.DesktopArticleTarget.addSurface @ VM31:1141
(anonymous) @ VM31:135
setTimeout (async)
(anonymous) @ VM31:135
setTimeout (async)
ve.init.mw.Target.setupSurface @ VM31:135
ve.init.mw.Target.documentReady @ VM31:133
ve.init.mw.ArticleTarget.documentReady @ VM31:578
ve.init.mw.ArticleTarget.loadSuccess @ VM31:577
ve.init.mw.DesktopArticleTarget.loadSuccess @ VM31:1144
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
jQuery.Deferred @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:190
then @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
(anonymous) @ VM30:16
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
jQuery.Deferred @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:190
then @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
OO.ui.Window.teardown @ VM30:26
(anonymous) @ VM30:16
setTimeout (async)
(anonymous) @ VM30:16
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
fireWith @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:85
mightThrow @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
process @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
setTimeout (async)
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
(anonymous) @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:88
jQuery.Deferred @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:190
then @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:87
OO.ui.Window.hold @ VM30:26
(anonymous) @ VM30:16
setTimeout (async)
(anonymous) @ VM30:16
fire @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:83
add @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:84
always @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:86
OO.ui.WindowManager.closeWindow @ VM30:16
OO.ui.Window.close @ VM30:25
(anonymous) @ VM30:31
(anonymous) @ VM30:7
OO.ui.Process.execute @ VM30:7
OO.ui.Dialog.executeAction @ VM30:30
OO.ui.Dialog.onActionClick @ VM30:27
oo.EventEmitter.emit @ VM21:162
oo.EventEmitter.emit @ VM21:162
OO.ui.mixin.ButtonElement.onClick @ load.php?debug=false&lang=en&modules=oojs-ui-core|oojs-ui-core.styles&skin=vector&version=06om5lh:26
dispatch @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:107
elemData.handle @ load.php?debug=false&lang=en&modules=ext.centralNotice.display|ext.uls.common%2Cinterface|jquery|jquery.spinner|mediawiki.ui.button&skin=vector&version=1u1yu6i:103
Esanders claimed this task.Oct 1 2018, 2:28 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.
gerritbot subscribed.Oct 1 2018, 2:28 PM

Change 463769 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Use consistent method for finding nearest cursor offset

https://gerrit.wikimedia.org/r/463769

gerritbot added a project: Patch-For-Review.Oct 1 2018, 2:28 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Oct 1 2018, 2:29 PM
Esanders added a comment.Oct 29 2018, 1:13 PM

I can reproduce the browser tab crashing, alarmingly even with JS disabled:

  1. Open a document with a single <hiero> node
  2. Disable JS
  3. Click to right of Hiero

Looks like this should be reported upstream.

Esanders added a comment.Oct 29 2018, 2:11 PM

Removing display:inline-block form the hiero seems to fix this *shrugs*.

gerritbot added a comment.Oct 29 2018, 2:12 PM

Change 470400 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/wikihiero@master] Get rid of display:inline-block from outer table

https://gerrit.wikimedia.org/r/470400

gerritbot added a comment.Oct 29 2018, 11:22 PM

Change 463769 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use consistent method for finding nearest cursor offset

https://gerrit.wikimedia.org/r/463769

gerritbot added a comment.Oct 29 2018, 11:23 PM

Change 470400 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Get rid of display:inline-block from outer table

https://gerrit.wikimedia.org/r/470400

gerritbot added a comment.Oct 29 2018, 11:29 PM

Change 470522 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (236effcd7)

https://gerrit.wikimedia.org/r/470522

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 30 2018, 12:01 AM
gerritbot added a comment.Oct 30 2018, 10:47 AM

Change 470522 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (236effcd7)

https://gerrit.wikimedia.org/r/470522

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Oct 30 2018, 10:49 AM
JTannerWMF added a project: Editing QA.Nov 6 2018, 5:28 PM
Ryasmeen mentioned this in T208914: Change recovery fails when the change inserted a reference.Nov 7 2018, 12:00 AM
Ryasmeen added a project: Verified.Nov 7 2018, 12:16 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.Nov 14 2018, 4:36 PM
• marcella closed this task as Resolved.Nov 19 2018, 4:36 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptNov 19 2018, 4:36 PM
kaldari subscribed.Dec 6 2018, 12:23 AM

@Esanders - It looks like the display:inline-block change caused a different bug, specifically, you can no longer have heiro elements inline in text (T210695). Could you take a look (or revert)?

TheDJ mentioned this in T184221: Conflict between WikiHiero Egyptian hieroglyphs and Minerva.Jan 19 2019, 10:14 AM
TheDJ subscribed.

And another 'bug' in T184221: Conflict between WikiHiero Egyptian hieroglyphs and Minerva

Peachey88 added a project: Regression.Jan 20 2019, 10:13 PM
Dvorapa mentioned this in T210695: Hieroglyphs are no longer inline.Jan 21 2019, 7:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits