Page MenuHomePhabricator
Create Task
Maniphest T202389

Add phan-taint-check-plugin to Wikibase extension
Closed, ResolvedPublic
Actions

Description

Would be nice to add phan-taint-check-plugin to Wikibase extensions

Details

SubjectRepoBranchLines +/-
Configure phan-taint-check 1.5.0mediawiki/extensions/Wikibasemaster+3 -0
Run seccheck on Wikibaseintegration/configmaster+1 -0
SpecialEntityUsage: Escape content passed to $wgContLang->convert()mediawiki/extensions/Wikibasemaster+3 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Aug 21 2018, 12:29 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptAug 21 2018, 12:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Umherirrender added a parent task: T201219: Enable phan-taint-check-plugin on all Wikimedia-deployed repositories after getting it to pass.Aug 21 2018, 12:40 PM
Umherirrender moved this task from Backlog to Wikimedia deployed on the phan-taint-check-plugin board.Aug 22 2018, 8:18 PM
gerritbot subscribed.Sep 2 2018, 3:18 AM

Change 457076 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Wikibase@master] Fix phan-taint-check-plugin issues

https://gerrit.wikimedia.org/r/457076

gerritbot added a project: Patch-For-Review.Sep 2 2018, 3:18 AM
Legoktm subscribed.Sep 2 2018, 3:21 AM

The remaining failures are in tests, except they're in repo/tests/ so the plugin doesn't ignore them...

gerritbot added a comment.Sep 3 2018, 1:35 PM

Change 457076 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] SpecialEntityUsage: Escape content passed to $wgContLang->convert()

https://gerrit.wikimedia.org/r/457076

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 3 2018, 2:00 PM
gerritbot added a comment.Sep 8 2018, 2:43 AM

Change 458987 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[mediawiki/extensions/Wikibase@master] Configure phan-taint-check 1.5.0

https://gerrit.wikimedia.org/r/458987

gerritbot added a comment.Sep 8 2018, 2:51 AM

Change 458990 had a related patch set uploaded (by Brian Wolff; owner: Brian Wolff):
[integration/config@master] Run seccheck on Wikibase

https://gerrit.wikimedia.org/r/458990

gerritbot added a comment.Sep 8 2018, 2:56 AM

Change 458990 merged by jenkins-bot:
[integration/config@master] Run seccheck on Wikibase

https://gerrit.wikimedia.org/r/458990

gerritbot added a comment.Sep 8 2018, 3:36 AM

Change 458987 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Configure phan-taint-check 1.5.0

https://gerrit.wikimedia.org/r/458987

Legoktm closed this task as Resolved.Sep 8 2018, 3:43 AM
Legoktm claimed this task.
ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Sep 8 2018, 4:00 AM
sbassett moved this task from Wikimedia deployed to Done on the phan-taint-check-plugin board.Oct 15 2019, 6:53 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 15 2019, 7:13 PM
sbassett triaged this task as Medium priority.Oct 15 2019, 7:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL