Page MenuHomePhabricator

ApiMain exception catching should also handle PHP7 Errors
Closed, ResolvedPublic

Description

ApiMain (and also api.php) tries to catch any Exception so as to provide a properly-formatted error message to the client instead of an HTML error page.

With PHP 7.0, some cases that produce an Exception in HHVM instead produce an Error. The API code should catch these too.

Event Timeline

Change 454302 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] API: Catch Errors as well as Exceptions

https://gerrit.wikimedia.org/r/454302

Change 454302 merged by jenkins-bot:
[mediawiki/core@master] API: Catch Errors as well as Exceptions

https://gerrit.wikimedia.org/r/454302