Maniphest T202445

Add better testing around ref-in-ref scenarios
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Arlolra
	Aug 21 2018, 7:53 PM

Tags

Referenced Files

None

Subscribers

Description

This was pointed out in https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/436192/14/lib/ext/Cite/index.js#429

As a fun fallout, mobile apps discovered that the body of the ref-in-ref should be processed before the ref itself,
https://gerrit.wikimedia.org/r/c/mediawiki/services/mobileapps/+/454278/1/test/diff/results/page_references-enwiki-List_of_highest-grossing_Indian_films.json#12

which went in as https://github.com/wikimedia/parsoid/commit/d8cc76c56f150966359d303884c2b25cfde249b5

Related Objects

Mentioned Here: T266294: PHP Notice: Undefined property: DOMElement::$ownerDocument (and related cascading errors)
T266356: Some ref error types in embedded content aren't marked up
T289331: Nested refs edge case handled different in Parsoid's Cite implementation.

Event Timeline

Arlolra created this task.Aug 21 2018, 7:53 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2018, 7:53 PM

Arlolra triaged this task as Medium priority.Aug 21 2018, 7:53 PM

• Mholloway subscribed.Aug 21 2018, 8:21 PM

ssastry moved this task from Needs Triage to Testing on the Parsoid board.Aug 28 2018, 11:23 PM

A bunch of work happened on the Cite implementation at the end of 2002 that probably satisfies this ticket.

See T289331 T266294 T266356 and others