Page MenuHomePhabricator

AbuseFilter warnings and errors are handled badly by the editor
Open, Needs TriagePublic

Description

Visit https://reading-web-staging.wmflabs.org/wiki/Harry_Potter#/abusefilter
Click edit.
Type

Lord Voldemort

to trigger an AbuseFilter rule

The mobile interface alerts the user that an issue occurred (but this is non-obvious)

it also requires the user to click "Learn more" to understand the nature of the warning.

Clicking learn more triggers a confusing workflow (the user is incorrectly asked if they want to abandon their edit)

And clicking cancel leaves the user with a confusing screen
Button is blank

Problems with errors

Type the phrase "I love marmite" into any edit and you will be disallowed from completing the edit.


This error does not look like an error and has similar problems to the other workflow.

Acceptance criteria

At minimum:

  • Add errorbox class to errors triggered by AbuseFilter
  • Add warningbox class to error
  • Add a label to AbuseFilterOverlay.options.confirmButton
  • Suppress the escape editor warning when switching to the AbuseFilterOverlay

Developer notes

Code lives in resources/mobile.editor.common/AbuseFilterPanel.js and resources/mobile.editor.common/AbuseFilterOverlay.js

Developer notes for designer

This message is not styled with the warningbox class. Adding the class makes it look like this:


Having a separate overlay to display this error is a little jarring to me and throwing to you in case you want to rethink this entire experience.

Replication in production

Anonymous users on Commons trying to create pages will hit this all the time:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2018, 9:27 PM
Jdlrobson renamed this task from AbuseFilter warnings are handled badly by the editor to AbuseFilter warnings and errors are handled badly by the editor.Aug 21 2018, 9:35 PM
Jdlrobson updated the task description. (Show Details)
JTannerWMF moved this task from To Triage to Freezer on the VisualEditor board.Feb 12 2019, 5:11 PM
Jdlrobson added a comment.EditedFri, Aug 30, 10:31 PM

This is very broken. Came across this again while documenting the mobile site's UI components (no label for close button and undefined for the title):
https://doc.wikimedia.org/MobileFrontend/master/js/ui/?path=/story/editor--abusefilteroverlay

Can we remove this workflow or should we fix it? This is a pretty bad experience for editors who hit it.

Jdlrobson updated the task description. (Show Details)Wed, Sep 4, 5:38 PM

Change 537223 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] mobile.editor.overlay: Use errorformat=html and display all error messages

https://gerrit.wikimedia.org/r/537223

In the patch I'm proposing removing this workflow. The user needs to read the message before they can proceed. We should not hide it behind another click/tap.