Page MenuHomePhabricator
Create Task
Maniphest T202464

[wmf.16] <br> displayed In MT warning message
Closed, ResolvedPublic
Actions

Description

Screen Shot 2018-08-21 at 2.42.15 PM.png (443×431 px, 53 KB)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Fix rendering of MT abuse warning message in CX1Petar.petkovicmediawiki/extensions/ContentTranslationmaster+18 -15
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Aug 21 2018, 10:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 21 2018, 10:24 PM
Nikerabbit subscribed.Aug 22 2018, 8:56 AM

It this CX1? The screenshot looks like CX1.

• Petar.petkovic added a comment.Aug 22 2018, 9:56 AM
In T202464#4522071, @Nikerabbit wrote:

It this CX1? The screenshot looks like CX1.

Yes, that is CX1. Patch for T200768 changed the message, with CX2 in mind, but it broke CX1.

We can:

  • Change how message in CX1 is displayed to parse <br> tags
  • Don't use the same message for CX1 and CX2
• Arrbee moved this task from Needs Triage to Check & Move on the ContentTranslation board.Sep 3 2018, 11:21 AM
• Arrbee triaged this task as Low priority.Sep 3 2018, 2:18 PM
• Arrbee moved this task from Check & Move to Bugs on the ContentTranslation board.
• Petar.petkovic merged a task: T203881: [[MediaWiki:Cx-mt-abuse-warning-text/sr-ec]] translation issue.Sep 8 2018, 4:05 PM
• Petar.petkovic added a subscriber: Kizule.
gerritbot subscribed.Sep 13 2018, 1:24 PM

Change 460355 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix rendering of MT abuse warning message in CX1

https://gerrit.wikimedia.org/r/460355

gerritbot added a project: Patch-For-Review.Sep 13 2018, 1:24 PM
• Petar.petkovic claimed this task.Sep 13 2018, 1:26 PM
• Petar.petkovic added a project: Language-2018-July-September.
• Petar.petkovic moved this task from Backlog to In Review on the Language-2018-July-September board.
gerritbot added a comment.Sep 19 2018, 7:55 PM

Change 460355 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix rendering of MT abuse warning message in CX1

https://gerrit.wikimedia.org/r/460355

• Petar.petkovic removed a project: Patch-For-Review.Sep 19 2018, 7:56 PM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-July-September board.
• Petar.petkovic removed a subscriber: gerritbot.
ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)).Sep 19 2018, 8:00 PM
Etonkovidova closed this task as Resolved.Sep 20 2018, 1:22 AM

Checked in cx1 - <br> is gone:

Screen Shot 2018-09-19 at 6.20.22 PM.png (431×278 px, 42 KB)

• Petar.petkovic moved this task from QA to Done on the Language-2018-July-September board.Sep 20 2018, 6:59 AM
Etonkovidova mentioned this in T205680: [wmf.23] CX2: <br> displayed in "Page already exists" warning.Sep 28 2018, 12:56 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits