Followup to the ticket T201437: Upgrade to PHP 7.2 and Symfony 4.1 we should also consider moving from Assetic, an unmaintained PHP-based asset management, to Webpack Encore.
Description
Description
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Samwilson | T201437 Upgrade to PHP 7.2 and Symfony 4.1 | |||
Resolved | Samwilson | T202471 GrantMetrics: Move from Assetic to Webpack Encore |
Event Timeline
Comment Actions
I know we didn't estimate this, but it had to be looked at as part of the Symfony 4 upgrade, so I carried on with it this morning and it's pretty much done.
Comment Actions
Symfony recommends we commit the production assets, which is great because then we don't need to worry about Node on Toolforge.
This PR needs review; currently deployed to staging: https://github.com/wikimedia/grantmetrics/pull/106
Comment Actions
PR merged, and deployed to staging. Huzza for no Node on the server. :)
I think we can close this?
Or do we want to try deploying to production again? It's probably about time.