Page MenuHomePhabricator

Set the focus back to the rule editor once an option from the dropdown is selected
Closed, ResolvedPublic

Description

With the switch to CodeEditor in AbuseFilter's rule editor, we lost one useful functionality. With the old textarea, when you would select a rule/variable/operator from the dropdown, your cursor would be positioned after it in the textarea, and the textarea would have focus, so you could continue typing right there. But with the new setup you have to first click on the editor. Can we restore old functaionality?

Details

Related Gerrit Patches:
mediawiki/extensions/AbuseFilter : masterFocus the Ace editor after having added text from dropdown

Event Timeline

Huji created this task.Aug 22 2018, 1:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 1:54 AM

Change 454488 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Focus the Ace editor after having added text from dropdown

https://gerrit.wikimedia.org/r/454488

Daimona claimed this task.Aug 22 2018, 9:04 AM

Change 454488 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Focus the Ace editor after having added text from dropdown

https://gerrit.wikimedia.org/r/454488

Daimona closed this task as Resolved.Aug 22 2018, 12:27 PM