Page MenuHomePhabricator

ActiveAbstract tests are failing
Closed, ResolvedPublic

Description

06:36:28 1) BackupDumperAbstractsTest::testPlain
06:36:28 Wikimedia\Rdbms\DBQueryError: A database query error has occurred. Did you forget to run your application's database schema updater after upgrading? 
06:36:28 Query: SELECT  page_id,page_len,page_is_redirect,page_latest,page_content_model  FROM `unittest_page`    WHERE page_namespace = '0' AND page_title = 'BackupDumperAbstractsTestPage1'  LIMIT 1  
06:36:28 Function: LinkCache::fetchPageRow
06:36:28 Error: 2014 Commands out of sync; you can't run this command now (/tmp/quibble-mysql-1fv6wjzk/socket)
06:36:28 
06:36:28 
06:36:28 /workspace/src/includes/libs/rdbms/database/Database.php:1458
06:36:28 /workspace/src/includes/libs/rdbms/database/Database.php:1428
06:36:28 /workspace/src/includes/libs/rdbms/database/Database.php:1198
06:36:28 /workspace/src/includes/libs/rdbms/database/Database.php:1655
06:36:28 /workspace/src/includes/libs/rdbms/database/Database.php:1746
06:36:28 /workspace/src/includes/cache/LinkCache.php:313
06:36:28 /workspace/src/includes/cache/LinkCache.php:270
06:36:28 /workspace/src/includes/Title.php:3542
06:36:28 /workspace/src/includes/Title.php:987
06:36:28 /workspace/src/extensions/ActiveAbstract/AbstractFilter.php:102
06:36:28 /workspace/src/includes/export/DumpFilter.php:81
06:36:28 /workspace/src/includes/export/ExportProgressFilter.php:39
06:36:28 /workspace/src/includes/export/WikiExporter.php:482
06:36:28 /workspace/src/includes/export/WikiExporter.php:423
06:36:28 /workspace/src/includes/export/WikiExporter.php:154
06:36:28 /workspace/src/maintenance/backup.inc:278
06:36:28 /workspace/src/extensions/ActiveAbstract/tests/phpunit/BackupDumperAbstractsTest.php:170
06:36:28 /workspace/src/tests/phpunit/MediaWikiTestCase.php:475
06:36:28 /workspace/src/maintenance/doMaintenance.php:94

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/12036/console

Event Timeline

Change 456687 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ActiveAbstract@master] Change abstract BackupDumper to DumpBackup in tests

https://gerrit.wikimedia.org/r/456687

Change 456687 merged by jenkins-bot:
[mediawiki/extensions/ActiveAbstract@master] Change abstract BackupDumper to DumpBackup in tests

https://gerrit.wikimedia.org/r/456687

is this still an issue? It wasn't even on my radar but I saw it now by a change search in phab.

is this still an issue? It wasn't even on my radar but I saw it now by a change search in phab.

No reply to previous comment and Umherirrender's patch on this ticket has been merged.
Assuming this task is resolved. @Legoktm: If not, please reopen this task via the Add Action...Change Status dropdown. Thanks!