Page MenuHomePhabricator

[NSFileRepo] No setting $wgContLang, use setContentLang() or setService( 'ContentLanguage' )
Closed, ResolvedPublic

Description

$wgContLang is deprecated T160815 . MediaWikiTestCase throws an exception whenever one attempts to set it in a test via setMwGlobals():

1) NSFileRepo\Tests\NamespaceListTest::testGetReadableNoTalks
MWException: No setting $wgContLang, use setContentLang() or setService( 'ContentLanguage' )

/workspace/src/tests/phpunit/MediaWikiTestCase.php:754
/workspace/src/extensions/NSFileRepo/tests/phpunit/NamespaceListTest.php:20
/workspace/src/tests/phpunit/MediaWikiTestCase.php:475
/workspace/src/maintenance/doMaintenance.php:94

2) NSFileRepo\Tests\NamespaceListTest::testGetReadableNoUnreadables
MWException: No setting $wgContLang, use setContentLang() or setService( 'ContentLanguage' )

/workspace/src/tests/phpunit/MediaWikiTestCase.php:754
/workspace/src/extensions/NSFileRepo/tests/phpunit/NamespaceListTest.php:20
/workspace/src/tests/phpunit/MediaWikiTestCase.php:475
/workspace/src/maintenance/doMaintenance.php:94

3) NSFileRepo\Tests\NamespaceListTest::testMediaWikiTestCaseParentSetupCalled
MWException: No setting $wgContLang, use setContentLang() or setService( 'ContentLanguage' )

/workspace/src/tests/phpunit/MediaWikiTestCase.php:754
/workspace/src/extensions/NSFileRepo/tests/phpunit/NamespaceListTest.php:20
/workspace/src/tests/phpunit/MediaWikiTestCase.php:475
/workspace/src/maintenance/doMaintenance.php:94

4) NSFileRepo\Tests\NamespaceListTest::testValidCovers
MWException: No setting $wgContLang, use setContentLang() or setService( 'ContentLanguage' )

/workspace/src/tests/phpunit/MediaWikiTestCase.php:754
/workspace/src/extensions/NSFileRepo/tests/phpunit/NamespaceListTest.php:20
/workspace/src/tests/phpunit/MediaWikiTestCase.php:475
/workspace/src/maintenance/doMaintenance.php:94

Details

Related Gerrit Patches:
mediawiki/extensions/NSFileRepo : masterRemove unneeded wgContLang from test suite
integration/config : masterMark NSFileRepo as broken

Event Timeline

hashar created this task.Aug 22 2018, 8:31 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 8:31 AM

Change 455172 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/NSFileRepo@master] Remove unneeded wgContLang from test suite

https://gerrit.wikimedia.org/r/455172

Change 455175 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Mark NSFileRepo as broken

https://gerrit.wikimedia.org/r/455175

Change 455175 merged by jenkins-bot:
[integration/config@master] Mark NSFileRepo as broken

https://gerrit.wikimedia.org/r/455175

Change 455172 merged by jenkins-bot:
[mediawiki/extensions/NSFileRepo@master] Remove unneeded wgContLang from test suite

https://gerrit.wikimedia.org/r/455172

hashar closed this task as Resolved.Aug 27 2018, 2:33 PM
hashar claimed this task.