Page MenuHomePhabricator

Do not run mediawiki-phpunit-coverage-patch-docker on wmf branches
Closed, ResolvedPublic


I would say nobody cares about the coverage in wmf branches[1], because it is only relevant on master.

In my opinion this job and cpu could be safed.

Maybe also skip release branches?


Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 8:54 AM

@Legoktm thoughts? I am also inclined to only run coverage patch for the master branch (and maybe for REL1_31 and later as well).

Agreed about skipping for wmf/ and REL1_ branches. It's main utility is for developers actively writing code, and nearly all of the patches to those branches are always cherry picks.

hashar assigned this task to Krinkle.Mar 18 2019, 12:46 PM
hashar closed this task as Resolved.
hashar added a subscriber: Krinkle.

8b45a9a4df8b2e56d4f262a23ea94d677d64dd58 introduced the job in Feb 2018 with:

  # Only run patch coverage if a PHP file was
  # changed on master.
- name: mediawiki-phpunit-coverage-patch
  branch: master
   - '^.*\.php$'

Eventually the job has been migrated to Docker and thus got renamed with a -docker suffix. Thus the rule no more matched.

Fixed by @Krinkle with 65247ad4306d62f529ed0ecbfef8ebff3fe9d3e2 :

Only run patch-coverage on master branch (as originally intended)

The job name was changed to *-docker a while back, such as "mwext-phpunit-coverage-patch-docker", which meant that this filter stopped working. Should help reduce CI load a bit.

     # Only run patch coverage if a PHP file was
     # changed on master.
-  - name: ^.*-phpunit-coverage-patch$
+  - name: ^.*-phpunit-coverage-patch