Page MenuHomePhabricator

Phabricator: Allow aklapper to delete personal Herald filter rules
Closed, ResolvedPublic

Event Timeline

Restricted Application edited projects, added SRE; removed Patch-For-Review. · View Herald TranscriptAug 22 2018, 10:23 AM

Will administrators at least attempt to warn users before deleting them? I'd appreciate so because as a Herald user (cf. H90) the interface doesn't let me know if the rule is being expensive or not. Thank you.

I'm not sure if this should be a SRE-Access-Requests or a request for the Release-Engineering-Team to approve (since they are the primary maintainers of the phabricator software, or both?

Since its an odd one, I can list it for review in our weekly SRE team meeting. This may be overkill though and just something that requires Release engineering approval (and then SRE can merge the patch.)

I'm not sure if this should be a SRE-Access-Requests

@RobH: I don't think so either but was told that "sudo changes need to be proposed via a task using the Ops-Access-Requests project".

True, yeah this needs SRE meeting review. I'll list it on next Monday's meeting!

Change 448505 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[operations/puppet@production] Phab: Allow aklapper to delete personal Herald filter rules

https://gerrit.wikimedia.org/r/448505

Change 448505 merged by Dzahn:
[operations/puppet@production] Phab: Allow aklapper to delete personal Herald filter rules

https://gerrit.wikimedia.org/r/448505

Once @Aklapper confirms the rule works as intended and he can delete heralds, yep.

Dzahn subscribed.

Yes, now that puppet ran on phab1001 and phab2001 and edited the sudo privileges.

+%phabricator-admin ALL = NOPASSWD: /srv/phab/phabricator/bin/remove destroy H*