Description
Details
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Phab: Allow aklapper to delete personal Herald filter rules | operations/puppet | production | +1 -0 |
Event Timeline
Will administrators at least attempt to warn users before deleting them? I'd appreciate so because as a Herald user (cf. H90) the interface doesn't let me know if the rule is being expensive or not. Thank you.
@MarcoAurelio: Basically https://www.mediawiki.org/w/index.php?title=Phabricator%2FHelp%2FHerald_Rules&type=revision&diff=2837388&oldid=2647356
It's not "one rule" to be expensive or not. It's the sheer amount in total.
I'm not sure if this should be a SRE-Access-Requests or a request for the Release-Engineering-Team to approve (since they are the primary maintainers of the phabricator software, or both?
Since its an odd one, I can list it for review in our weekly SRE team meeting. This may be overkill though and just something that requires Release engineering approval (and then SRE can merge the patch.)
@RobH: I don't think so either but was told that "sudo changes need to be proposed via a task using the Ops-Access-Requests project".
Change 448505 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[operations/puppet@production] Phab: Allow aklapper to delete personal Herald filter rules
Change 448505 merged by Dzahn:
[operations/puppet@production] Phab: Allow aklapper to delete personal Herald filter rules
Yes, now that puppet ran on phab1001 and phab2001 and edited the sudo privileges.
+%phabricator-admin ALL = NOPASSWD: /srv/phab/phabricator/bin/remove destroy H*