Page MenuHomePhabricator

Separate ref analysis code from wikidata import
Closed, DuplicatePublic


Currently Vesihiisi/Biblioteksdata/importer contains the code for both the reference processing and authority imports.

These should be split up into two directories as they deal with different things.

Event Timeline

Since the authority importer is still on a separate branch, I'll do the separation before merging it.

Since you are moving the refs (not the authority importer) it would be more clean to have that move in a separate PR. It makes it easier to follow what is happening in the repo, easier to diff between commits and thus easier to isolate which commit is responsible for something breaking later (when needed).

I think the rule of thumb is make your PR (=the squashed commit) be atomic. It fixes one bug, adds one feature or makes one stylistic change.