Page MenuHomePhabricator
Create Task
Maniphest T202512

Remove 100% width on mobile page-issue
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To
Ryasmeen
Authored By
Jdrewniak
Aug 22 2018, 11:18 AM
Tags
Referenced Files
F25464682: Screen Shot 2018-08-28 at 1.01.38 PM.png
Aug 28 2018, 11:02 AM
F25445564: Screen Shot 2018-08-27 at 3.58.17 PM.png
Aug 27 2018, 11:02 PM
F25321915: Screen Shot 2018-08-24 at 3.13.58 PM.png
Aug 24 2018, 7:32 PM
F25321896: Screen Shot 2018-08-24 at 3.30.37 PM.png
Aug 24 2018, 7:32 PM
F25321907: Screen Shot 2018-08-24 at 3.30.53 PM.png
Aug 24 2018, 7:32 PM
F25260323: Screen Shot 2018-08-23 at 13.23.13.png
Aug 23 2018, 11:33 AM
F25260298: Screen Shot 2018-08-23 at 13.17.04.png
Aug 23 2018, 11:33 AM
F25260313: Screen Shot 2018-08-23 at 13.20.20.png
Aug 23 2018, 11:33 AM
View All 13 Files
Subscribers
Aklapper
• alexhollender_WMF
gerritbot
jan
Jdlrobson
Jdrewniak
ovasileva

Description

the new page-issues style on mobile shouldn't be given a 100% width, because section issues might get weird when they're next to an infobox (on tablet widths anyway).

Screen Shot 2018-08-22 at 13.00.31.png (2×2 px, 897 KB)
Screen Shot 2018-08-22 at 13.00.57.png (2×2 px, 1 MB)
Screen Shot 2018-08-22 at 13.01.19.png (2×2 px, 1 MB)
badbetterVector

Fix: remove line #30 in ambox.less

QA steps

  • Click the issues to open the issues overlay and check they display as expected in the overlay.

Details

SubjectRepoBranchLines +/-
On tablet, issues boxes shouldn't take up full screenmediawiki/skins/MinervaNeuemaster+1 -1
Customize query in gerrit

Event Timeline

Jdrewniak created this task.Aug 22 2018, 11:18 AM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 22 2018, 11:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdrewniak added a project: Readers-Web-Kanbanana-Board-Old.Aug 22 2018, 11:25 AM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Aug 22 2018, 3:36 PM
Jdlrobson set the point value for this task to 2.Aug 22 2018, 3:46 PM
ovasileva moved this task from Upcoming to Current Sprint (and resolved 2018-19 Q1) pre-milestone on the Web-Team-Backlog board.Aug 22 2018, 3:49 PM
Jdlrobson changed the point value for this task from 2 to 3.Aug 22 2018, 3:55 PM
Jdlrobson subscribed.

Estimation bumped from 2 to 3 as there is a little risk here given ambox templates are usually tables and table CSS rules might come into conflict here.

Jdlrobson claimed this task.Aug 22 2018, 8:02 PM
Jdlrobson moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.
Jdlrobson moved this task from Current Sprint (and resolved 2018-19 Q1) pre-milestone to Readers-Web-Kanbanana-Board-2018-19-Q1 on the Web-Team-Backlog board.Aug 22 2018, 8:06 PM
Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.
Restricted Application edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1). · View Herald TranscriptAug 22 2018, 8:06 PM
Jdlrobson moved this task from Doing to Quarterly Goals on the Readers-Web-Kanbanana-Board-Old board.Aug 22 2018, 9:33 PM
Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog, Readers-Web-Kanbanana-Board-Old.
Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Aug 22 2018, 9:39 PM
Jdlrobson updated the task description. (Show Details)Aug 22 2018, 9:53 PM
gerritbot subscribed.Aug 22 2018, 9:54 PM

Change 454704 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] On tablet, issues boxes shouldn't take up full screen

https://gerrit.wikimedia.org/r/454704

gerritbot added a project: Patch-For-Review.Aug 22 2018, 9:54 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Aug 22 2018, 9:55 PM
Jdlrobson added a subscriber: jan.

Looks like @jan was right, this did prove to be an easy one unless I'm overlooking something.

Jdrewniak added a comment.Aug 23 2018, 11:33 AM

Looks good! I think the QA here is pretty simple, so I tested this on several devices in browser stack.
Tested on iPhone, iPad, Google Nexus in Chrome and Firefox.

Screen Shot 2018-08-23 at 13.17.04.png (1×678 px, 363 KB)
Screen Shot 2018-08-23 at 13.18.10.png (1×1 px, 933 KB)
Screen Shot 2018-08-23 at 13.20.20.png (964×1 px, 727 KB)
Screen Shot 2018-08-23 at 13.23.13.png (930×1 px, 689 KB)
Screen Shot 2018-08-23 at 13.24.48.png (1×1 px, 651 KB)
iPhone XiPadNexus 7Nexus 9

As seen on the Nexus 9 example, even thought the issue text is very short, the issue still stretched to fill the available space, while letting the infobox sit beside it. So LGTM! I don't think this needs further QA. I can pass it on the @alexhollender for sign-off.

Jdrewniak reassigned this task from Jdlrobson to • alexhollender_WMF.Aug 23 2018, 11:34 AM
Jdrewniak moved this task from Needs Code Review to Needs Design Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
gerritbot added a comment.Aug 23 2018, 11:39 AM

Change 454704 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] On tablet, issues boxes shouldn't take up full screen

https://gerrit.wikimedia.org/r/454704

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 23 2018, 12:00 PM
• alexhollender_WMF updated the task description. (Show Details)Aug 24 2018, 7:30 PM
• alexhollender_WMF reassigned this task from • alexhollender_WMF to Ryasmeen.Aug 24 2018, 7:32 PM
• alexhollender_WMF moved this task from Needs Design Review to Needs QA on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
• alexhollender_WMF added a project: Product-QA.

Looks good.

United States ArmyThe AnimatrixEri Kitamura
Screen Shot 2018-08-24 at 3.30.37 PM.png (989×1 px, 412 KB)
Screen Shot 2018-08-24 at 3.30.53 PM.png (989×1 px, 447 KB)
Screen Shot 2018-08-24 at 3.13.58 PM.png (989×1 px, 369 KB)
Ryasmeen added a comment.Aug 27 2018, 11:02 PM

Looks good to me for the first two articles on all three resolutions. The display of the issues overlay also looks fine. No issues with other tables on those articles.

I don't see any page issues for the article "United_States_Army" though! So could not verify it for that article. Other than that, all good from my side.

Screen Shot 2018-08-27 at 3.58.17 PM.png (571×1 px, 295 KB)

ovasileva closed this task as Resolved.Aug 28 2018, 11:02 AM
ovasileva moved this task from Needs QA to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

@Ryasmeen - perhaps you weren't in the correct bucket? I was able to see them:

Screen Shot 2018-08-28 at 1.01.38 PM.png (599×1 px, 300 KB)

Looks good! I'm going to go ahead and resolve this.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL