Page MenuHomePhabricator

Remove 100% width on mobile page-issue
Closed, ResolvedPublic3 Estimated Story Points

Description

the new page-issues style on mobile shouldn't be given a 100% width, because section issues might get weird when they're next to an infobox (on tablet widths anyway).

Screen Shot 2018-08-22 at 13.00.31.png (2×2 px, 897 KB)
Screen Shot 2018-08-22 at 13.00.57.png (2×2 px, 1 MB)
Screen Shot 2018-08-22 at 13.01.19.png (2×2 px, 1 MB)
badbetterVector

Fix: remove line #30 in ambox.less

QA steps

  • Click the issues to open the issues overlay and check they display as expected in the overlay.

Event Timeline

Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptAug 22 2018, 11:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson set the point value for this task to 2.Aug 22 2018, 3:46 PM
Jdlrobson changed the point value for this task from 2 to 3.Aug 22 2018, 3:55 PM
Jdlrobson added a subscriber: Jdlrobson.

Estimation bumped from 2 to 3 as there is a little risk here given ambox templates are usually tables and table CSS rules might come into conflict here.

Change 454704 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] On tablet, issues boxes shouldn't take up full screen

https://gerrit.wikimedia.org/r/454704

Jdlrobson added a subscriber: jan.

Looks like @jan was right, this did prove to be an easy one unless I'm overlooking something.

Looks good! I think the QA here is pretty simple, so I tested this on several devices in browser stack.
Tested on iPhone, iPad, Google Nexus in Chrome and Firefox.

Screen Shot 2018-08-23 at 13.17.04.png (1×678 px, 363 KB)
Screen Shot 2018-08-23 at 13.18.10.png (1×1 px, 933 KB)
Screen Shot 2018-08-23 at 13.20.20.png (964×1 px, 727 KB)
Screen Shot 2018-08-23 at 13.23.13.png (930×1 px, 689 KB)
Screen Shot 2018-08-23 at 13.24.48.png (1×1 px, 651 KB)
iPhone XiPadNexus 7Nexus 9

As seen on the Nexus 9 example, even thought the issue text is very short, the issue still stretched to fill the available space, while letting the infobox sit beside it. So LGTM! I don't think this needs further QA. I can pass it on the @alexhollender for sign-off.

Change 454704 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] On tablet, issues boxes shouldn't take up full screen

https://gerrit.wikimedia.org/r/454704

Looks good to me for the first two articles on all three resolutions. The display of the issues overlay also looks fine. No issues with other tables on those articles.

I don't see any page issues for the article "United_States_Army" though! So could not verify it for that article. Other than that, all good from my side.

Screen Shot 2018-08-27 at 3.58.17 PM.png (571×1 px, 295 KB)

@Ryasmeen - perhaps you weren't in the correct bucket? I was able to see them:

Screen Shot 2018-08-28 at 1.01.38 PM.png (599×1 px, 300 KB)

Looks good! I'm going to go ahead and resolve this.