Page MenuHomePhabricator
Create Task
Maniphest T202587

"Leave site?" message erroneously shown after user has saved an edit and is back in read mode
Closed, ResolvedPublic
Actions

Description

User edits and after pushing [publish], gets a message "leave page? changes you made may not be saved"

Screen Shot 2018-08-08 at 2.46.07 PM.png (900×1 px, 498 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+8 -0Release editWarning unload event when switching from old wikitext to VE
Customize query in gerrit

Related Objects

Event Timeline

• aripstra created this task.Aug 22 2018, 10:06 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 22 2018, 10:06 PM
Deskana changed the task status from Open to Stalled.Aug 23 2018, 11:41 AM
Deskana added a subscriber: Deskana.

I can't reproduce this problem. Here's what I tried:

  1. Go to https://office.wikimedia.org/wiki/Leadership/Executive_Team_Weekly_Updates/2018_August_7 (which seems to be the exact page you were on)
  2. Click "Edit" to open the visual editor
  3. Make some changes
  4. Click "Publish"
  5. Navigate away from the page using a link on the page

All of these steps worked as expected, and no error message was shown to me. I also tried the same steps except I started out in the wikitext editor and then switched to the visual editor, and started out in the wikitext editor and switched to the visual editor, and couldn't reproduce the problem.

Can you please provide more specific steps to reproduce?

Deskana renamed this task from Chrome message to "Leave site?" message erroneously shown after user has saved an edit and is back in read mode.Aug 23 2018, 11:45 AM
• ggellerman added a comment.Aug 23 2018, 7:16 PM

In Chrome:

  1. go to https://office.wikimedia.org/w/index.php?title=Leadership/Executive_Team_Weekly_Updates/2018_August_21 and click Edit, it takes me to wikitext editor.
  2. Switch to visual editor
  3. make some changes
  4. click Publish
  5. Get chrome warning

I don't always get the warning. I tried editing the same page and trying steps 1-4 more than once to see if it only happens the first time I try to save, but it happened twice on the same page.

Deskana triaged this task as Medium priority.Aug 24 2018, 4:47 PM
Deskana moved this task from To Triage to Up next on the VisualEditor board.

I've managed to reproduce this now. I had to disable the 2017 wikitext editor, and also use single edit tab mode set to wikitext editing by default.

Deskana changed the task status from Stalled to Open.Aug 24 2018, 4:47 PM
• ggellerman added a comment.Aug 24 2018, 4:54 PM

Thanks, @Deskana ! Let me know if you need more specifics from me.

Deskana moved this task from Up next to Needs Discussion/Analysis on the VisualEditor board.Sep 5 2018, 4:16 PM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 5 2018, 5:49 PM
Esanders claimed this task.Sep 6 2018, 12:46 PM
Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.Sep 6 2018, 1:13 PM
gerritbot added a subscriber: gerritbot.Sep 6 2018, 1:17 PM

Change 458501 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Release editWarning unload event when switching from old wikitext to VE

https://gerrit.wikimedia.org/r/458501

gerritbot added a project: Patch-For-Review.Sep 6 2018, 1:17 PM
Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Sep 6 2018, 1:17 PM
Jdforrester-WMF edited projects, added VisualEditor-MediaWiki; removed Patch-For-Review.Sep 6 2018, 3:19 PM
Jdforrester-WMF moved this task from Code review to QA on the VisualEditor (Current work) board.
gerritbot added a comment.Sep 6 2018, 3:33 PM

Change 458501 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Release editWarning unload event when switching from old wikitext to VE

https://gerrit.wikimedia.org/r/458501

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 6 2018, 4:00 PM
Ryasmeen added a project: Verified.Sep 6 2018, 8:55 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Esanders mentioned this in T204185: type=frame images are not resizeable, VE makes user think they are.Sep 24 2018, 1:31 PM
Esanders merged a task: T205289: "Leave site?" dialog shown after switching from 2010WTE to VE and saving.Sep 24 2018, 2:47 PM
Esanders mentioned this in T205289: "Leave site?" dialog shown after switching from 2010WTE to VE and saving.
Esanders added subscribers: Esanders, Volker_E.
Deskana closed this task as Resolved.Sep 28 2018, 10:09 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL