'editcontentmodel' missing in metawiki's MassMessage sender group
Open, Stalled, LowestPublic

Description

A metawiki MassMessage sender just reported to me that Special:CreateMassMessageList throws a permission error at him.
This should obiously not be the case. In order to solve this issue, the 'editcontentmodel' permission needs to be assigned to the 'massmessage-sender' user group on metawiki.

Vogone created this task.Aug 23 2018, 1:33 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2018, 1:33 AM
Teles added a subscriber: Teles.Aug 23 2018, 2:34 AM

This is not an "error" it is by design. Simply being able to use the massmessage extension doesn't require changing content models.

This is not an "error" it is by design. Simply being able to use the massmessage extension doesn't require changing content models.

Creating MassMessage delivery lists does. It clearly belongs to the workflow and is not controversial at all.

True, however that access allows for much more than only creating massmessage delivery lists. I'd 100% support a configuration that allows massmessage people to use that special createlist function without also needing to be able to change content models on every page as the default.

MarcoAurelio triaged this task as Lowest priority.Aug 23 2018, 7:47 AM
MarcoAurelio claimed this task.
MarcoAurelio changed the task status from Open to Stalled.
MarcoAurelio added a subscriber: MarcoAurelio.

AFAIK the editcontentmodel priv was thought to be made avalaible to
autoconfirmed users elsewhere, but some people, me included, shared
Xaosflux's concerns that it could be used to mess with pages by vandals.

Restricted Application added a project: User-MarcoAurelio. · View Herald TranscriptAug 23 2018, 7:47 AM

Change 454762 had a related patch set uploaded (by Vogone; owner: Vogone):
[operations/mediawiki-config@master] This change adds the permission 'editcontentmodel' to the 'massmessage-senders' user group on metawiki. The change will allow 'massmessage-senders' on metawiki to use Special:CreateMassMessageList.

https://gerrit.wikimedia.org/r/454762

Vogone claimed this task.Aug 23 2018, 8:23 AM

Change 454762 had a related patch set uploaded (by Vogone; owner: Vogone):
[operations/mediawiki-config@master] This change adds the permission 'editcontentmodel' to the 'massmessage-senders' user group on metawiki. The change will allow 'massmessage-senders' on metawiki to use Special:CreateMassMessageList.

https://gerrit.wikimedia.org/r/454762

Someone convinced me it would be a good idea to try the gerrit web interface. Unfortunately, I do not seem to be able to find the option to edit an actual file. A follow-up patch in the traditional way will follow.

@Vogone If you're using the new UI (PolyGerrit) you can't edit patches. Switch to the old UI (there should be a link at the footer of the page) then go to the patch and you'll see an Edit button on the patch that'll let you edit, add, rename and remove files. Then Done editting and Publish edit (at the top} and you're all set. When you think the patch is ready for review hit Start Review so it appears on people's review dashboards. Let me know if I can help. Regards.

Xaosflux added a comment.EditedAug 23 2018, 2:16 PM

Follow up from: https://meta.wikimedia.org/w/index.php?title=Meta:Babel&oldid=18322653#'editcontentmodel'_permission_for_'massmessage-senders'

Would it be feasible to change the 'Special:CreateMassMessageList' permissions checking from 'editcontentmodel' to 'massmessage' ? In general we allow the creation of non-wikitext pages in special workflows already, just not this one.

  • Update, just removing 'editcontentmodel' checks from this process doesn't seem too much of problem for me either - yes people could make lists in inappropriate places, but they can be deleted as easily as other things they make there.

@Vogone If you're using the new UI (PolyGerrit) you can't edit patches. Switch to the old UI (there should be a link at the footer of the page) then go to the patch and you'll see an Edit button on the patch that'll let you edit, add, rename and remove files. Then Done editting and Publish edit (at the top} and you're all set. When you think the patch is ready for review hit Start Review so it appears on people's review dashboards. Let me know if I can help. Regards.

Thanks for the summary, things have gotten clearer to me now. :-)

Follow up from: https://meta.wikimedia.org/w/index.php?title=Meta:Babel&oldid=18322653#'editcontentmodel'_permission_for_'massmessage-senders'

Would it be feasible to change the 'Special:CreateMassMessageList' permissions checking from 'editcontentmodel' to 'massmessage' ? In general we allow the creation of non-wikitext pages in special workflows already, just not this one.

  • Update, just removing 'editcontentmodel' checks from this process doesn't seem too much of problem for me either - yes people could make lists in inappropriate places, but they can be deleted as easily as other things they make there.

Preferaby we should discuss this in a separate task since such a change would affect the extension rather than the site configuration.

@Vogone, this could be re titled - unless you want to build a community consensus on metawiki for changing their group only - I think in the discussion so far we've identified that this is really a "global" problem that could be fixed a few ways.

@Vogone, this could be re titled - unless you want to build a community consensus on metawiki for changing their group only - I think in the discussion so far we've identified that this is really a "global" problem that could be fixed a few ways.

No, as MarcoAurelio has ligned out, the task about the "bug" is T92795. This ticket here is a mere request for a change to the site config of metawiki, which may or may not be approved by the community (at the moment it rather looks like the latter case).

Just note that Central notice administrators have the editinterface right, as said by https://meta.wikimedia.org/wiki/Special:ListGroupRights?uselang=en.