Maniphest T202629

removeEmptySections function of cosmetic_changes.py sometimes removes large sections of a page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dalba
	Aug 23 2018, 2:24 PM

Description

Originally reported by Hercule Antoine on the mailing list:

I have another problem with CC :
https://fr.wikipedia.org/w/index.php?title=Wikip%C3%A9dia:Le_Bistro/Articles_%C3%A0_cr%C3%A9er_en_2013&diff=prev&oldid=151563699

Some sections are removed but I don't see what is different from the others. It just appends when CC are on.

Details

	Subject	Repo	Branch	Lines +/-
	CosmeticChangesToolkit.removeEmptySections: Fix skipping of language links	pywikibot/core	master	+20 -8

Customize query in gerrit

Event Timeline

Dalba created this task.Aug 23 2018, 2:24 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptAug 23 2018, 2:24 PM

Dalba renamed this task from removeEmptySections function of cosmetic_changes.py sometimes remove large sections of a page to removeEmptySections function of cosmetic_changes.py sometimes removes large sections of a page.Aug 23 2018, 2:25 PM

Dalba triaged this task as High priority.

Change 454853 had a related patch set uploaded (by Dalba; owner: dalba):
[pywikibot/core@master] CosmeticChangesToolkit.removeEmptySections: Do not skip interwikis

https://gerrit.wikimedia.org/r/454853

gerritbot added a project: Patch-For-Review.Aug 23 2018, 4:24 PM

I managed to minimize the issue to the following input:

text [[:en:link]]
=== title1 ===
content1

The diff after applying cosmetic changes:

@@ -2,2 +1,0 @@
- === title1 ===
- content1

Dalba claimed this task.Aug 23 2018, 4:40 PM

Change 454853 merged by jenkins-bot:
[pywikibot/core@master] CosmeticChangesToolkit.removeEmptySections: Fix skipping of language links

https://gerrit.wikimedia.org/r/454853

Dalba closed this task as Resolved.Aug 24 2018, 4:49 AM

removeEmptySections function of cosmetic_changes.py sometimes removes large sections of a pageClosed, ResolvedPublicActions

Description

Details

Event Timeline

removeEmptySections function of cosmetic_changes.py sometimes removes large sections of a page
Closed, ResolvedPublic
Actions