Page MenuHomePhabricator
Create Task
Maniphest T202651

Section number in issues is reported incorrectly.
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

When visiting http://reading-web-staging.wmflabs.org/w/index.php?title=Roman_Catholic_Diocese_of_Darwin&mobileaction=toggle_view_mobile and clicking the issue in the history section, the section number 2 doesn't correspond with the actual section number (1). This will cause problems in our instrumentation.

This appears to relate to the mobile-toc that is added by MobileFrontend which contains an h2.

The fix is relatively simple - updating the selector in Page.HEADING_SELECTOR or providing a function that filters out the h2.

Details

SubjectRepoBranchLines +/-
Section headings should exclude table of contents headingmediawiki/extensions/MobileFrontendmaster+77 -21
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Aug 23 2018, 5:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2018, 5:55 PM
Jdlrobson moved this task from Incoming to Upcoming on the Web-Team-Backlog board.Aug 23 2018, 5:55 PM
Jdlrobson added a parent task: T202098: Log sectionNumbers in PageIssues schema.Aug 23 2018, 6:00 PM
Jdlrobson set the point value for this task to 3.Aug 23 2018, 8:50 PM
Jdlrobson edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.

From async estimation: provisional 3. We can talk about this Monday during standup. I will work on this now.

Jdlrobson claimed this task.Aug 23 2018, 8:50 PM
Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.
gerritbot subscribed.Aug 23 2018, 10:18 PM

Change 455018 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Section headings should exclude table of contents heading

https://gerrit.wikimedia.org/r/455018

gerritbot added a project: Patch-For-Review.Aug 23 2018, 10:18 PM
Jdlrobson moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Aug 23 2018, 10:20 PM
gerritbot added a comment.Aug 24 2018, 12:03 AM

Change 455018 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Section headings should exclude table of contents heading

https://gerrit.wikimedia.org/r/455018

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)).Aug 24 2018, 1:00 AM
ovasileva triaged this task as High priority.Aug 24 2018, 10:07 AM
Jdlrobson moved this task from Needs Code Review to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Aug 24 2018, 5:06 PM

Skipping design review (none necessary) and QA which will happen as part of T191532

Jdlrobson reassigned this task from Jdlrobson to • Tbayer.Aug 27 2018, 9:50 PM

To be signed off as part of next rubber ducky session (to be organised)

• Tbayer closed this task as Resolved.Aug 31 2018, 5:00 PM
• Tbayer added a subscriber: Jdrewniak.

@Jdrewniak and I double-checked this again today and the correction section number is now sent in this example.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL