Page MenuHomePhabricator

Improve Accept header normalization in VCL for REST API
Closed, ResolvedPublic

Description

In order to support content negotiation for Parsoid HTML, we need to set Vary: Accept in Parsoid HTML response. To avoid severe cache fragmentation, some accept header normalization was already added to VCL.

However, we will ignore semver patch version changes as upgrading/downgrading the content can hurt latency, create additional load on Parsoid and patch version bumps must not break the clients, so we need to have more normalization - replace the semver patch version number with x.

Event Timeline

Pchelolo triaged this task as Medium priority.Aug 23 2018, 10:39 PM
Pchelolo created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Pchelolo renamed this task from Improve multi-content-bucket designA to Improve Accept header normalization in VCL for REST API.Aug 23 2018, 10:40 PM

Change 455036 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[operations/puppet@production] Replace the semver patch version in Accept with x

https://gerrit.wikimedia.org/r/455036

Change 455036 merged by Ema:
[operations/puppet@production] Replace the semver patch version in Accept with 0

https://gerrit.wikimedia.org/r/455036

mobrovac assigned this task to Pchelolo.

Since node's semver package does not deal with .x versions well, we settled for forcing the patch component of the version to be .0.