Page MenuHomePhabricator
Create Task
Maniphest T202718

Remove notice specific to PayPal from donation form
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To
None
Authored By
kai.nissen
Aug 24 2018, 11:09 AM
Tags
Referenced Files
F25304429: donation-form-paypal-notice-10h16-p1.png
Aug 24 2018, 11:19 AM
F25304312: donation-form-paypal-notice.png
Aug 24 2018, 11:19 AM
F25304428: donation-form-paypal-notice-10h16-p2.png
Aug 24 2018, 11:19 AM
Subscribers
Aklapper
gabriel-wmde
kai.nissen
• Tonina_Zhelyazkova_WMDE

Description

For some time, PayPal restricted recurring payments to accounts for which credit card data was provided. This is not the case anymore. Users can now also subscribe if they handle their PayPal payments by direct debit.

When users choose a recurring payment and select PayPal as the payment method, a notice is displayed in the form ("Für regelmäßige Spenden muss bei PayPal eine Kreditkarte hinterlegt sein."). There is a similar notice in the membership form, although PayPal is not enabled as a payment type right now. It is based on the payment type selection only, since membership fees are always recurring.

Both notices and the underlying functionality can now be removed from both skins.

Acceptance Criteria

  • The notice regarding credit card data in PayPal accounts is not displayed in the donation form of skin cat17.
  • The notice regarding credit card data in PayPal accounts is not displayed in the membership form of skin cat17.
  • The notice regarding credit card data in PayPal accounts is not displayed in the donation form of skin 10h16.
  • The notice regarding credit card data in PayPal accounts is not displayed in the membership form of skin 10h16.

donation-form-paypal-notice.png (556×618 px, 41 KB)

donation-form-paypal-notice-10h16-p1.png (695×615 px, 66 KB)

donation-form-paypal-notice-10h16-p2.png (82×609 px, 14 KB)

Related Objects

Event Timeline

kai.nissen created this task.Aug 24 2018, 11:09 AM
Restricted Application added a project: WMDE-FUN-Team. · View Herald TranscriptAug 24 2018, 11:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
kai.nissen updated the task description. (Show Details)Aug 24 2018, 11:19 AM
kai.nissen set the point value for this task to 2.Aug 27 2018, 9:21 AM
kai.nissen moved this task from Backlog to Sprint ready on the WMDE-Fundraising-Tech board.Sep 3 2018, 2:36 PM
• Tonina_Zhelyazkova_WMDE subscribed.Sep 12 2018, 10:05 AM

I wanted to pick this task but seems like it's already been done. I don't see the message neither on test spenden nor on spenden for both skins.
Also, AFAIK we don't have the PayPal option in the membership form.
@kai.nissen can you please confirm if the task is done?

kai.nissen added a comment.Sep 12 2018, 10:31 AM

It's still there. Did you select any of the recurring payments and PayPal as the payment processor?

Paying with PayPal is disabled for membership applications. You can enable it in your local configuration file to see the notice.

kai.nissen added a project: WMDE-FUN-Sprint-2018-09-17.Sep 17 2018, 10:24 AM
kai.nissen moved this task from Sprint ready to Current Sprint on the WMDE-Fundraising-Tech board.Sep 17 2018, 10:30 AM
• Tonina_Zhelyazkova_WMDE claimed this task.Sep 17 2018, 3:13 PM
• Tonina_Zhelyazkova_WMDE moved this task from Todo to Doing on the WMDE-FUN-Sprint-2018-09-17 board.
• Tonina_Zhelyazkova_WMDE added a comment.Sep 17 2018, 4:01 PM

https://github.com/wmde/FundraisingFrontend/pull/1330

• Tonina_Zhelyazkova_WMDE removed • Tonina_Zhelyazkova_WMDE as the assignee of this task.Sep 17 2018, 4:01 PM
• Tonina_Zhelyazkova_WMDE moved this task from Doing to Review on the WMDE-FUN-Sprint-2018-09-17 board.
gabriel-wmde moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-09-17 board.Sep 19 2018, 8:40 AM
gabriel-wmde subscribed.Sep 19 2018, 8:54 AM

While reviewing the code, I discovered T204808: cat17 skin does not show Paypal membership information on delayed payment

gabriel-wmde moved this task from Deploy to Test to Review on the WMDE-FUN-Sprint-2018-09-17 board.Sep 19 2018, 8:58 AM

Small follow-up in https://github.com/wmde/FundraisingFrontend/pull/1331

• Tonina_Zhelyazkova_WMDE moved this task from Review to Deploy to Test on the WMDE-FUN-Sprint-2018-09-17 board.Sep 19 2018, 9:58 AM
• Tim_WMDE moved this task from Deploy to Test to Test on the WMDE-FUN-Sprint-2018-09-17 board.Sep 24 2018, 12:00 PM
kai.nissen moved this task from Test to Deploy on the WMDE-FUN-Sprint-2018-09-17 board.Sep 26 2018, 3:00 PM
gabriel-wmde added a project: WMDE-Fun-Sprint-2018-10-01.Oct 1 2018, 10:22 AM
gabriel-wmde moved this task from Todo to Deploy on the WMDE-Fun-Sprint-2018-10-01 board.
• Tonina_Zhelyazkova_WMDE moved this task from Deploy to Done on the WMDE-Fun-Sprint-2018-10-01 board.Oct 5 2018, 8:12 AM
kai.nissen closed this task as Resolved.Oct 30 2018, 10:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL