Page MenuHomePhabricator

When creating a new Sense through wbeditentity the summary is confusing "Created a new entity"
Closed, ResolvedPublic5 Story Points

Description

Given what people already know about Wikidata & Wikibase creating these new sub entities and having the same edit summary as when creating "full" entities could get confusing.

It might be an idea to change the summary to state that it is creating a new subentity?
Or specifically say that it is creating a new Sense?

I imagine the same thing is true for Forms

Event Timeline

Lydia_Pintscher added a subscriber: Lydia_Pintscher.

Yeah "Added a new Sense" and "Added a new Form" would be better.

Ladsgroup set the point value for this task to 5.Aug 28 2018, 11:05 AM
Ladsgroup claimed this task.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 28 2018, 11:05 AM

Change 455827 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/Wikibase@master] [WIP] Pass entity type to edit summary in wbeditentity

https://gerrit.wikimedia.org/r/455827

Change 455828 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/WikibaseLexeme@master] Add messages for creating new lexeme, form, and sense via wbeditentity

https://gerrit.wikimedia.org/r/455828

Change 455827 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Pass entity type to edit summary in wbeditentity

https://gerrit.wikimedia.org/r/455827

Change 455828 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add messages for creating new lexeme, form, and sense via wbeditentity

https://gerrit.wikimedia.org/r/455828

Pintoch added a subscriber: Pintoch.Sep 5 2018, 5:34 PM

@Lydia_Pintscher @Ladsgroup any idea how I could be notified of any new automatic edit summaries, such as the wbeditentity-create-item that this change introduced? For any such summary, I need to add it to EditGroups, especially if the new auto summary replaces a highly-used existing one, as in this case. Otherwise, this breaks the tagging of batches.

More broadly, is the list of these auto summaries exposed anywhere? To write EditGroups I extracted it from the localization files of Wikibase, but that's not really ideal.

I am not requesting a stable interface policy or anything like that - it's great that these auto summaries become more informative!

@Lydia_Pintscher @Ladsgroup any idea how I could be notified of any new automatic edit summaries, such as the wbeditentity-create-item that this change introduced? For any such summary, I need to add it to EditGroups, especially if the new auto summary replaces a highly-used existing one, as in this case. Otherwise, this breaks the tagging of batches.

Hmmm, I can't really think of a reliable process to do that.

More broadly, is the list of these auto summaries exposed anywhere? To write EditGroups I extracted it from the localization files of Wikibase, but that's not really ideal.

You can look at the localization files and try to figure it all out, for example https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/master/repo/i18n/qqq.json#228.
But you would also have to look through all of the Wikibase extensions etc.
And they are not all grouped together in the i18n files anyway.

They aren't even all in once place in code to expose in any nice way.

I am not requesting a stable interface policy or anything like that - it's great that these auto summaries become more informative!

You best bet is probably just to make EditGroups handle unknown summaries in a more generic way or improve the ability to match new automatic summaries there.