Page MenuHomePhabricator

[BUG] iPhone 5s search empty view layout bugs
Closed, ResolvedPublic

Description

How many times were you able to reproduce it?

Every

Steps to reproduce

  1. clean app install
  2. tap on Saved icon
  3. tap on Search places text box

Expected results

empty view should not be cut off

Actual results

yep, it's cut off

Screenshots

Environments observed

App version:
6.0.0
OS versions:
11.4
Device model:
iPhone 5s (and others)
Device language:
All

Testing criteria

Ensure Places > Search Places empty view isn't cut off.

Event Timeline

Mhurd updated the task description. (Show Details)
JMinor triaged this task as Medium priority.Aug 27 2018, 8:41 PM

TSG doesn't have an iPhone 5s so if @JoeWalsh has confirmed it fixed I will let it be.

LGoto added subscribers: JoeWalsh, LGoto.

Hi Anthony, I think you finished this, but can you confirm? Thanks!

@ABorbaWMF Testing with iOS 10.3.3 (iPhone 6s) [this is one of the "(and others)" device models as TSG doesn't have an iPhone 5] and Wikipedia app 6.1.0 (1491). According to the screencap below Places > Search Places empty view isn't cut off on this device/build pairing.

@Nicholas.tsg please test on iphone SE. It should have roughly the same screen size.

@ABorbaWMF Testing with iOS 12 (iPhone SE) and Wikipedia app 6.0.2 (1493). According to the screencap below Places > Search Places empty view isn't cut off on this device/build pairing either.