Maniphest T202799

[BUG] iPhone 5s search empty view layout bugs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Mhurd
	Aug 25 2018, 6:58 AM

Tags

Referenced Files

	F26216350: T202799.PNG
	Sep 27 2018, 1:41 AM

	F26201709: T202799.jpg
	Sep 25 2018, 7:41 PM

	F25338588: iphone 5s bug 2.png
	Aug 25 2018, 6:58 AM

	F25338589: iphone 5s bug.png
	Aug 25 2018, 6:58 AM

Subscribers

• NHarateh_WMF

Description

How many times were you able to reproduce it?

Every

Steps to reproduce

clean app install
tap on Saved icon
tap on Search places text box

Expected results

empty view should not be cut off

Actual results

yep, it's cut off

Screenshots

iphone 5s bug.png (911×550 px, 144 KB)

Environments observed

App version:
6.0.0
OS versions:
11.4
Device model:
iPhone 5s (and others)
Device language:
All

Testing criteria

Ensure Places > Search Places empty view isn't cut off.

Related Objects

Duplicates Merged Here: T202801: [BUG] Places recent searches layout issue on iPhone 5s

Event Timeline

Mhurd created this task.Aug 25 2018, 6:58 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2018, 6:58 AM

Mhurd updated the task description. (Show Details)Aug 25 2018, 7:00 AM

Mhurd updated the task description. (Show Details)

JoeWalsh claimed this task.Aug 27 2018, 8:29 PM

JoeWalsh added a project: iOS-app-v6.0.1-Walrus-On-A-Golf-Cart.

JoeWalsh moved this task from Tasks from Product Backlog to Needs Code Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 27 2018, 8:32 PM

• NHarateh_WMF merged a task: T202801: [BUG] Places recent searches layout issue on iPhone 5s.Aug 27 2018, 8:38 PM

• NHarateh_WMF subscribed.

• JMinor triaged this task as Medium priority.Aug 27 2018, 8:41 PM

• JMinor moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.Aug 27 2018, 8:45 PM

• NHarateh_WMF moved this task from Needs Code Review to Needs Testing Criteria on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 28 2018, 1:44 PM

Mhurd added a project: Regression.Aug 28 2018, 7:52 PM

Mhurd updated the task description. (Show Details)

Mhurd moved this task from Needs Testing Criteria to Needs Design Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.

Thanks for this great fix @JoeWalsh!

TSG doesn't have an iPhone 5s so if @JoeWalsh has confirmed it fixed I will let it be.

Hi Anthony, I think you finished this, but can you confirm? Thanks!

LGoto moved this task from Tasks from Product Backlog to Needs QA on the iOS-app-v6.1-Narwhal-On-A-Bumper-Car board.Sep 24 2018, 6:38 PM

@ABorbaWMF Testing with iOS 10.3.3 (iPhone 6s) [this is one of the "(and others)" device models as TSG doesn't have an iPhone 5] and Wikipedia app 6.1.0 (1491). According to the screencap below Places > Search Places empty view isn't cut off on this device/build pairing.

T202799.jpg (1×750 px, 131 KB)

@Nicholas.tsg please test on iphone SE. It should have roughly the same screen size.

@ABorbaWMF Testing with iOS 12 (iPhone SE) and Wikipedia app 6.0.2 (1493). According to the screencap below Places > Search Places empty view isn't cut off on this device/build pairing either.

T202799.PNG (1×640 px, 97 KB)

ABorbaWMF moved this task from Needs QA to Ready for PM Signoff on the iOS-app-v6.1-Narwhal-On-A-Bumper-Car board.Sep 27 2018, 5:33 AM

• JMinor closed this task as Resolved.Nov 6 2018, 11:00 PM