Steps to reproduce:
- go to the beta deploy wiki, get a PHP shell
- run User::newSystemUser('<non-existent user>')
Will yield PHP Notice: Trying to get property of non-object in /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/DatabaseMysqli.php on line 233
The full trace is
1: Psy\Shell->handleError() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/DatabaseMysqli.php:233 2: Wikimedia\Rdbms\DatabaseMysqli->mysqlNumRows() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/DatabaseMysqlBase.php:362 3: Wikimedia\Rdbms\DatabaseMysqlBase->numRows() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php:1257 4: Wikimedia\Rdbms\Database->doProfiledQuery() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php:1155 5: Wikimedia\Rdbms\Database->query() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php:3893 6: Wikimedia\Rdbms\Database->doCommit() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php:3864 7: Wikimedia\Rdbms\Database->commit() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php:3664 8: Wikimedia\Rdbms\Database->endAtomic() at /srv/mediawiki-staging/php-master/includes/libs/rdbms/database/Database.php:3752 9: Wikimedia\Rdbms\Database->doAtomicSection() at /srv/mediawiki-staging/php-master/includes/user/User.php:4322 10: User::createNew() at /srv/mediawiki-staging/php-master/includes/user/User.php:848 11: User::newSystemUser() at eval()'d code:2