Page MenuHomePhabricator
Create Task
Maniphest T202875

Remove request for feedback from AdvancedSearch form
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Motivation
Once AdvancedSearch becomes a default, we do not want to use up space permanently with a request for feedback. Right now, we have the following sentence in the interface:

Bildschirmfoto 2018-08-27 um 10.58.10.png (176×1 px, 36 KB)

Acceptance Criteria

  • Remove the request for feedback

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove request for feedback linkmediawiki/extensions/AdvancedSearchmaster+3 -24
Customize query in gerrit

Related Objects

Event Timeline

• Lea_WMDE created this task.Aug 27 2018, 8:59 AM
Restricted Application added a project: TCB-Team (now WMDE-TechWish). · View Herald TranscriptAug 27 2018, 8:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
• Lea_WMDE moved this task from Tickets ready for pickup to Backlog on the Advanced-Search board.Aug 27 2018, 9:01 AM
• Lea_WMDE updated the task description. (Show Details)Aug 27 2018, 9:07 AM
• Lea_WMDE set the point value for this task to 1.
gerritbot subscribed.Oct 29 2018, 11:30 PM

Change 470523 had a related patch set uploaded (by Tim Eulitz; owner: Tim Eulitz):
[mediawiki/extensions/AdvancedSearch@master] Remove request for feedback link

https://gerrit.wikimedia.org/r/470523

gerritbot added a project: Patch-For-Review.Oct 29 2018, 11:30 PM
• Tim_WMDE added a project: WMDE-FUN-Sprint-2018-10-29.Oct 29 2018, 11:31 PM
• Tim_WMDE moved this task from Todo to Review on the WMDE-FUN-Sprint-2018-10-29 board.
• Tim_WMDE added subscribers: • Tonina_Zhelyazkova_WMDE, gabriel-wmde, • Tim_WMDE.EditedOct 29 2018, 11:33 PM

I randomly remembered that we discussed we would remove this before the go-live of AdvancedSearch so I quickly did this before we would forget about it. Please quickly double-check that I did not miss anything or deleted too much by accident @Tonina_Zhelyazkova_WMDE @gabriel-wmde.

Also added myself and Kai to the extension.json after Tonina's remark yesterday, did not want to make a separate ticket for that but I can remove it from the commit if you think that is problematic / dirty.

• Tim_WMDE mentioned this in rEASR812121506d26: Remove request for feedback link.Oct 29 2018, 11:56 PM
gerritbot added a comment.Oct 30 2018, 11:15 AM

Change 470523 merged by jenkins-bot:
[mediawiki/extensions/AdvancedSearch@master] Remove request for feedback link

https://gerrit.wikimedia.org/r/470523

• Tim_WMDE moved this task from Review to Done on the WMDE-FUN-Sprint-2018-10-29 board.Oct 30 2018, 11:23 AM
ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.2; 2018-10-30).Oct 30 2018, 12:01 PM
thiemowmde closed this task as Resolved.Nov 19 2018, 8:20 AM
thiemowmde claimed this task.
• Lea_WMDE moved this task from Backlog to In FUN sprint on the Advanced-Search board.Dec 4 2018, 9:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits