Page MenuHomePhabricator

Visual editor toolbar momentarily distorts and becomes very large when scrolling in Safari, but the problem is intermittent
Closed, ResolvedPublic

Description

Steps to reproduce:

  1. Using Safari, go to https://en.wikipedia.org/wiki/Cannibal!_The_Musical
  2. Open the article in the visual editor
  3. Scroll up and down in the article a little bit

Expected results:

  • The toolbar at the top moves smoothly

Actual results:

  • When moving, the toolbar at the top sometimes momentarily distorts for a fraction of a second

Screen Shot 2018-08-27 at 21.21.06.png (1×2 px, 930 KB)

Event Timeline

Deskana renamed this task from Visual editor toolbar momentarily distorts when scrolling in Safari to Visual editor toolbar momentarily distorts and becomes very large when scrolling in Safari.Aug 27 2018, 8:28 PM

Tested this a fair bit on Safari 11.1.2 and couldn't get it to trigger. Looks like a browser or OS bug though, so might be not much we can do about it.

Which version are you using, as is it still reproduceable?

It's still happening for me. Safari 11.1.2, macOS 10.13.6.

The problem seems to be intermittent. At first it didn't happen on Dublin for me, but then when I left editing mode completely and re-entered it, it started happening again. Then I tabbed out to write this comment here, and when I tabbed back to Safari, it wasn't happening any more. Then I reloaded again, and it started happening again. On this article, the distortion is huge, which makes me wonder whether it's related to article size somehow? I can't upload a screenshot right now, as I'm on a shaky connection, but it's basically the same as the screenshot in the description, except the distortion is half the height of my screen. (!!!)

Meanwhile, on some articles like Hazel Grove, I can't seem to get it to happen at all no matter how hard I try.

Deskana renamed this task from Visual editor toolbar momentarily distorts and becomes very large when scrolling in Safari to Visual editor toolbar momentarily distorts and becomes very large when scrolling in Safari, but the problem is intermittent.Sep 2 2018, 12:55 PM

My screenshot finally made it!

Screen Shot 2018-09-02 at 13.44.08.png (1×2 px, 960 KB)

@Deskana: That's definitely a crazy browser bug. My first guess would be the transform property as that usually triggers GPU rendering which could go wrong.

If you can reliably reproduce this locally, can you try running this in the console after the editor loads, and see if it makes a difference:

$('.ve-init-mw-desktopArticleTarget-toolbar-open > .oo-ui-toolbar-bar').css('transform', 'none')

@Esanders When I experience this issue, running that JS fixes it for the rest of that edit session. It seems like you're on to it!

Change 460521 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Turn off CSS transforms after toolbar has been opened

https://gerrit.wikimedia.org/r/460521

Change 460521 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Turn off CSS transforms after toolbar has been opened

https://gerrit.wikimedia.org/r/460521

Yep, can no longer reproduce. Nice!