Maniphest T202939

Integrate page library change for 6.0.1
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• JMinor
	Aug 27 2018, 8:57 PM

Tags

Referenced Files

	F25668739: IMG_0069.PNG
	Sep 5 2018, 6:01 PM

	F25668742: IMG_2246.PNG
	Sep 5 2018, 6:01 PM

	F25668740: IMG_0068.PNG
	Sep 5 2018, 6:01 PM

Subscribers

Description

Integrate fix in parent ticket.

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T169242 Develop Page Content Service for Reading Clients
		Resolved		None	T177425 Develop General Layer of PCS
		Resolved		None	T177433 Develop HTML Content API to be used with companion structured JSON APIs
		Resolved		• bearND	T201381 Infoboxes too narrow on wide devices
		Resolved		Mhurd	T202939 Integrate page library change for 6.0.1

Event Timeline

• JMinor created this task.Aug 27 2018, 8:57 PM

• JMinor triaged this task as Medium priority.

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.

LGoto reassigned this task from • bearND to Mhurd.Aug 27 2018, 8:57 PM

Mhurd moved this task from Ready for Development to Doing on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 27 2018, 10:01 PM

https://github.com/wikimedia/wikipedia-ios/pull/2625

Mhurd moved this task from Doing to Needs Code Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 28 2018, 7:08 PM

• bearND mentioned this in T203024: Update page library version for Android app to avoid narrow infoboxes on wide devices.Aug 28 2018, 9:03 PM

JoeWalsh moved this task from Needs Code Review to Needs Design Review on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.Aug 29 2018, 4:04 PM

JoeWalsh moved this task from Needs Design Review to Needs QA on the iOS-app-v6.0.1-Walrus-On-A-Golf-Cart board.

@Mhurd Are there steps to repro here?

For this you need a wide enough device, e.g. an iPhone 6 Plus in landscape mode or an iPad,
then open the Cat page,
open the collapsed infobox table

Check if you see the infobox content all narrow and horizontal scrollbar, or taking the whole screen. The latter is expected.

LGTM on 6.0.1 (1486). I tried a few other articles as well

IMG_0069.PNG (1×2 px, 1 MB)

IMG_0068.PNG (2×1 px, 1 MB)

IMG_2246.PNG (1×2 px, 1 MB)

• JMinor closed this task as Resolved.Sep 24 2018, 10:01 PM