Page MenuHomePhabricator
Create Task
Maniphest T202978

Move MobileFrontend's VisualEditor styles back to MobileFrontend
Closed, ResolvedPublic
Actions

Description

See T140807#4526439.

These styles were moved to Minerva, but should have stayed in MF.

Details

SubjectRepoBranchLines +/-
Remove 'mobile.editor.ve' styles (move to MobileFrontend)mediawiki/skins/MinervaNeuemaster+0 -53
Add 'mobile.editor.ve' styles (move from Minerva)mediawiki/extensions/MobileFrontendmaster+53 -0
mobile.editor.ve: Simplify left/right border of toolbar on >1000px screensmediawiki/skins/MinervaNeuemaster+6 -8
Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStylesmediawiki/skins/MinervaNeuemaster+56 -57
mobile.editor.ve: Simplify margin/padding for debug barmediawiki/skins/MinervaNeuemaster+0 -4
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
 DeclinedNoneT144571 Mobile Media Viewer violates user settings
 OpenJdlrobsonT65504 Consolidate code for MediaViewer across desktop and mobile
 DeclinedNoneT162210 [EPIC] Upstream MobileFrontend components to core and other extensions (tracking)
 DuplicateJdlrobsonT66316 [EPIC] Move Nearby code to more suitable extension
 OpenNoneT49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core
 OpenNoneT100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core
 DeclinedNoneT96202 [EPIC] Rewrite MobileFrontend frontend code in OOUI
 OpenNoneT106267 mobile phone wikitext editor should have edit toolbar
 OpenNoneT106266 Provide a "signature" button in the mobile wikitext editor
 OpenNoneT171974 Improve and consolidate our unified editing platform so that it's great on all devices
 OpenNoneT159971 Provide the VE wikitext editing mode as the mobile wikitext editor
 DuplicateNoneT101462 [EPIC] Merge OOJS UI library and Mobile unnamed library.
 OpenNoneT96186 [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor
 ResolvedmatmarexT198765 Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop)
 ResolvedmatmarexT202978 Move MobileFrontend's VisualEditor styles back to MobileFrontend
 ResolvedovasilevaT205382 Remove code related to no-anonymous-editing mode of MobileFrontend ($wgMFEditorOptions['anonymousEditing'] = false;)
 ResolvedABorbaWMFT208514 Merge PageIssues Feature Branch to Master
 ResolvedNoneT206178 Feature branch: Remove pageIssues A-B test code

Event Timeline

Esanders created this task.Aug 28 2018, 10:17 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2018, 10:17 AM
• Deskana moved this task from To Triage to External and Administrivia on the VisualEditor board.Aug 28 2018, 6:34 PM
matmarex added a parent task: T198765: Move mobile editor code from Minerva skin to MobileFrontend, use it for all skins on mobile (and none on desktop).Aug 29 2018, 1:15 AM
Esanders added a subscriber: Krinkle.Sep 11 2018, 1:33 PM
In T140807#4527918, @Krinkle wrote:

@Esanders Aye, yes, that makes sense!

I moved that file as part me helping Reading-Web finish their move of Minerva-specific styles from MobileFrontend to Minerva. I understood that Reading-Web prefers to keep these customisations centralised in the Minerva repository – which also allows them to re-use code by sharing a Less-variables import between them.

The main motivation behind this move was 1) Reading's goal of MobileFrontend not depending on Minerva (and vice-versa), and 2) Performance's goal of removing use of the deprecated hook that allowed that dependency to exist in an implicit way.

This file could certainly be moved back to MobileFrontend, in one of two ways: 1) Change the stylesheet to not use Minerva's shared import, or 2) By making the module in MobileFrontend explicitly depend on Minerva through a FileModule subclass that exists in Minerva. Whichever direction you choose, I'd recommend discussing that further with Reading-Web, as I can't decide this :)

Esanders added a subscriber: Jdlrobson.Sep 11 2018, 1:33 PM
In T140807#4535358, @Jdlrobson wrote:

TBH in the long term, I'd like to see all the VisualEditor Mobile code moved to VisualEditor and integrated with MobileFrontend. Likewise I'd like to see all the Echo code move to Echo. I think this is important as that's where your code lives and ideally MobileFrontend integration can happen inside one repo.

I think it's fine to move these skin styles to MobileFrontend if possible. I seem to recall there were issues adding styles here for some reason due to how skin/extension registration works but I forget what, so be careful if doing this, that the styles still apply.

• marcella assigned this task to matmarex.Sep 13 2018, 2:51 PM
• marcella moved this task from External and Administrivia to Up next on the VisualEditor board.
• marcella added a project: Technical-Debt.
Jdlrobson added a parent task: T96186: [EPIC] Move VisualEditor code from MobileFrontend to VisualEditor.Sep 14 2018, 5:25 PM
• marcella edited projects, added VisualEditor (Current work); removed VisualEditor.Sep 17 2018, 3:24 PM
pmiazga added a project: Web-Team-Backlog (Tracking).Sep 17 2018, 8:29 PM
gerritbot subscribed.Sep 17 2018, 8:43 PM

Change 460976 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] mobile.editor.ve: Simplify margin/padding for debug bar

https://gerrit.wikimedia.org/r/460976

gerritbot added a project: Patch-For-Review.Sep 17 2018, 8:43 PM

Change 460977 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] mobile.editor.ve: Simplify left/right border of toolbar on >1000px screens

https://gerrit.wikimedia.org/r/460977

gerritbot added a comment.Sep 17 2018, 9:16 PM

Change 460985 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles

https://gerrit.wikimedia.org/r/460985

gerritbot added a comment.Sep 17 2018, 9:31 PM

Change 460988 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/skins/MinervaNeue@master] Remove 'mobile.editor.ve' styles (move to MobileFrontend)

https://gerrit.wikimedia.org/r/460988

gerritbot added a comment.Sep 17 2018, 9:31 PM

Change 460989 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Add 'mobile.editor.ve' styles (move from Minerva)

https://gerrit.wikimedia.org/r/460989

matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Sep 17 2018, 9:44 PM
matmarex added a comment.Sep 17 2018, 9:53 PM
In T140807#4527918, @Krinkle wrote:

This file could certainly be moved back to MobileFrontend, in one of two ways: 1) Change the stylesheet to not use Minerva's shared import, (…)

Done. My first two patches above remove uses of two of Minerva's variables.

In T140807#4535358, @Jdlrobson wrote:

I think it's fine to move these skin styles to MobileFrontend if possible. I seem to recall there were issues adding styles here for some reason due to how skin/extension registration works but I forget what, so be careful if doing this, that the styles still apply.

Minerva was adding the styles to the 'mobile.editor.ve' module from MobileFrontend using ResourceModuleSkinStyles; after my patch, MobileFrontend will add them directly when registering the module. This should have exactly the same effect.

Esanders awarded a token.Sep 17 2018, 11:51 PM
gerritbot added a comment.Sep 18 2018, 12:17 PM

Change 460976 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] mobile.editor.ve: Simplify margin/padding for debug bar

https://gerrit.wikimedia.org/r/460976

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 18 2018, 1:01 PM
gerritbot added a comment.Sep 18 2018, 3:38 PM

Change 460977 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] mobile.editor.ve: Simplify left/right border of toolbar on >1000px screens

https://gerrit.wikimedia.org/r/460977

gerritbot added a comment.Sep 18 2018, 3:40 PM

Change 460985 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Move Parsoid output overrides to 'mediawiki.skinning.content.parsoid' skinStyles

https://gerrit.wikimedia.org/r/460985

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)); removed MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 18 2018, 4:00 PM
gerritbot added a comment.Sep 18 2018, 4:45 PM

Change 460988 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove 'mobile.editor.ve' styles (move to MobileFrontend)

https://gerrit.wikimedia.org/r/460988

gerritbot added a comment.Sep 18 2018, 4:45 PM

Change 460989 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Add 'mobile.editor.ve' styles (move from Minerva)

https://gerrit.wikimedia.org/r/460989

• marcella awarded a token.Sep 18 2018, 5:52 PM
matmarex moved this task from Code review to Product owner review on the VisualEditor (Current work) board.Sep 18 2018, 8:34 PM
• Deskana closed this task as Resolved.Sep 27 2018, 1:30 PM
• Deskana added a project: Editing Q1 2018-19 mobile improvements.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL