Page MenuHomePhabricator
Create Task
Maniphest T202990

Mobile: Deactivated selections have a higher z-index than toolbars
Closed, ResolvedPublic
Actions

Description

image.png (1,140×620 px, 135 KB)

Doesn't appear to be an issue on desktop, even though we use the same technique.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove z-index:6 hack from VE mobile overlaysmediawiki/skins/MinervaNeuemaster+0 -5
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Aug 28 2018, 1:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2018, 1:26 PM
Esanders claimed this task.Aug 28 2018, 1:26 PM
Esanders edited projects, added: VisualEditor (Current work); removed: VisualEditor.
gerritbot subscribed.Aug 28 2018, 1:26 PM

Change 455832 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/skins/MinervaNeue@master] Remove z-index:6 hack from VE mobile overlays

https://gerrit.wikimedia.org/r/455832

gerritbot added a project: Patch-For-Review.Aug 28 2018, 1:26 PM
Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Aug 28 2018, 1:27 PM
Esanders added a comment.Aug 28 2018, 1:31 PM

This is a follow-up on T201329

• Deskana triaged this task as Medium priority.Aug 28 2018, 4:03 PM
• Deskana added a project: Editing Q1 2018-19 mobile improvements.
gerritbot added a comment.Aug 28 2018, 6:43 PM

Change 455832 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove z-index:6 hack from VE mobile overlays

https://gerrit.wikimedia.org/r/455832

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 28 2018, 7:00 PM
Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Aug 28 2018, 10:35 PM
Ryasmeen subscribed.Aug 31 2018, 8:42 PM

To be verified on production next week.

Ryasmeen added a project: Verified-in-Phase2.Sep 6 2018, 9:43 PM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
Jdforrester-WMF removed a project: Patch-For-Review.Sep 13 2018, 11:38 PM
• Deskana closed this task as Resolved.Sep 28 2018, 10:03 AM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 28 2018, 10:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits