Page MenuHomePhabricator
Create Task
Maniphest T203006

PHP Fatal Error: Call to undefined method ZeroBanner\\ZeroConfig::getLicenseObject()
Closed, ResolvedPublic
Actions

Description

A 500 is returned from zero.wikimedia.org for any request for a page in the Zero namespace.

PHP Fatal Error from line 734 of /srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCSingleton.php: Call to undefined method ZeroBanner\ZeroConfig::getLicenseObject()

{
 "fatal_exception":
  { 
    "class":"ErrorException",
    "message":"PHP Fatal Error: Call to undefined method ZeroBanner\\ZeroConfig::getLicenseObject()",
    "code":16777217,
    "file":"/srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCSingleton.php",
    "line":734,
    "trace":"#0 /srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCSingleton.php(734): NO_FUNCTION_GIVEN()
  }
}
[721897cd88e5c4299cfcf548] /wiki/Zero:Foo Error from line 734 of /vagrant/mediawiki/extensions/JsonConfig/includes/JCSingleton.php: Call to undefined method ZeroBanner\ZeroConfig::getLicenseObject()

Backtrace:

#0 /vagrant/mediawiki/extensions/JsonConfig/includes/JCSingleton.php(824): JsonConfig\JCSingleton::getTitleLicenseCode(JsonConfig\JCTitle)
#1 /vagrant/mediawiki/includes/Hooks.php(174): JsonConfig\JCSingleton::onSkinCopyrightFooter(Title, string, string, string, boolean)
#2 /vagrant/mediawiki/includes/Hooks.php(202): Hooks::callHook(string, array, array, NULL)
#3 /vagrant/mediawiki/includes/skins/Skin.php(855): Hooks::run(string, array)
#4 /vagrant/mediawiki/includes/skins/SkinTemplate.php(397): Skin->getCopyright()
#5 /vagrant/mediawiki/includes/skins/SkinTemplate.php(225): SkinTemplate->prepareQuickTemplate()
#6 /vagrant/mediawiki/includes/OutputPage.php(2406): SkinTemplate->outputPage()
#7 /vagrant/mediawiki/includes/MediaWiki.php(875): OutputPage->output(boolean)
#8 /vagrant/mediawiki/includes/MediaWiki.php(887): MediaWiki->{closure}()
#9 /vagrant/mediawiki/includes/MediaWiki.php(525): MediaWiki->main()
#10 /vagrant/mediawiki/index.php(42): MediaWiki->run()
#11 /var/www/w/index.php(5): require(string)
#12 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check if content instanceof JCDataContent before calling getLicenseObjectmediawiki/extensions/JsonConfigwmf/1.32.0-wmf.19+1 -1
Check if content instanceof JCDataContent before calling getLicenseObjectmediawiki/extensions/JsonConfigwmf/1.32.0-wmf.18+1 -1
Check if content instanceof JCDataContent before calling getLicenseObjectmediawiki/extensions/JsonConfigmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

• Mholloway created this task.Aug 28 2018, 4:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2018, 4:28 PM
• Mholloway moved this task from To Do to Doing on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 28 2018, 4:30 PM
• Mholloway updated the task description. (Show Details)
• Mholloway updated the task description. (Show Details)
• Mholloway updated the task description. (Show Details)Aug 28 2018, 4:33 PM
• Mholloway updated the task description. (Show Details)Aug 28 2018, 4:43 PM
gerritbot subscribed.Aug 28 2018, 5:07 PM

Change 455868 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/JsonConfig@master] Check if getLicenseObject method exists before calling

https://gerrit.wikimedia.org/r/455868

gerritbot added a project: Patch-For-Review.Aug 28 2018, 5:07 PM
• Mholloway moved this task from Doing to Code Review on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 28 2018, 5:08 PM
gerritbot added a comment.Aug 28 2018, 6:12 PM

Change 455868 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Check if content instanceof JCDataContent before calling getLicenseObject

https://gerrit.wikimedia.org/r/455868

• Mholloway moved this task from Code Review to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Aug 28 2018, 6:45 PM
• Mholloway added a comment.Aug 28 2018, 6:53 PM

Looks like the branch cut was earlyish today and this didn't make it. I think I'll have it swatted.

gerritbot added a comment.Aug 28 2018, 6:55 PM

Change 455893 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[mediawiki/extensions/JsonConfig@wmf/1.32.0-wmf.19] Check if content instanceof JCDataContent before calling getLicenseObject

https://gerrit.wikimedia.org/r/455893

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)).Aug 28 2018, 7:00 PM
• Mholloway added a project: ZeroPortal.Aug 28 2018, 7:11 PM
Jdlrobson added a project: Web-Team-Backlog-Archived (Tracking).Aug 28 2018, 7:19 PM
Jdforrester-WMF mentioned this in T203029: Config:Dashiki:* on Meta can't be opened.Aug 28 2018, 10:01 PM
gerritbot added a comment.Aug 28 2018, 10:03 PM

Change 456033 had a related patch set uploaded (by Jforrester; owner: Mholloway):
[mediawiki/extensions/JsonConfig@wmf/1.32.0-wmf.18] Check if content instanceof JCDataContent before calling getLicenseObject

https://gerrit.wikimedia.org/r/456033

gerritbot added a comment.Aug 28 2018, 10:21 PM

Change 455893 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@wmf/1.32.0-wmf.19] Check if content instanceof JCDataContent before calling getLicenseObject

https://gerrit.wikimedia.org/r/455893

gerritbot added a comment.Aug 28 2018, 10:33 PM

Change 456033 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@wmf/1.32.0-wmf.18] Check if content instanceof JCDataContent before calling getLicenseObject

https://gerrit.wikimedia.org/r/456033

Stashbot subscribed.Aug 28 2018, 10:36 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-28T22:36:33Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.19/extensions/JsonConfig/includes/JCSingleton.php: Hot-deploy T203006 fix (duration: 00m 57s)

Stashbot added a comment.Aug 28 2018, 10:37 PM

Mentioned in SAL (#wikimedia-operations) [2018-08-28T22:37:37Z] <jforrester@deploy1001> Synchronized php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCSingleton.php: Hot-deploy T203006 fix (duration: 00m 56s)

Jdforrester-WMF edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), Patch-For-Review.Aug 28 2018, 10:38 PM
Jdforrester-WMF moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
Jdforrester-WMF subscribed.

Now hot-deployed.

• Jhernandez closed this task as Resolved.Nov 19 2018, 3:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits