Maniphest T203023

skins.monobook.mobile.uls dependency doesn't do mobile?
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	Jdforrester-WMF
	Aug 28 2018, 8:26 PM

Description

Running tests/phpunit/structure/ResourcesTest.php on master, I get:

1) ResourcesTest::testUnsatisfiableDependencies
The module 'skins.monobook.mobile.uls' must not have target 'mobile' because its dependency 'ext.uls.interface' does not have it
Failed asserting that an array contains 'mobile'.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/MonoBook	master	+51 -46	Refactor: Simplify responsive Monobook's optional dependencies

Customize query in gerrit

Related Objects

Mentioned In: rSMNB3bed284b3711: Refactor: Simplify responsive Monobook's optional dependencies

Event Timeline

Jdforrester-WMF created this task.Aug 28 2018, 8:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2018, 8:26 PM

So I guess the question is, is this depending on the wrong module, or should it not even be in mobile anymore, or... what?

What was this for?

Change 618401 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] Refactor: Simplify responsive Monobook's optional dependencies

https://gerrit.wikimedia.org/r/618401

gerritbot added a project: Patch-For-Review.Aug 4 2020, 10:09 PM

Change 618401 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Refactor: Simplify responsive Monobook's optional dependencies

https://gerrit.wikimedia.org/r/618401

Jdlrobson mentioned this in rSMNB3bed284b3711: Refactor: Simplify responsive Monobook's optional dependencies.Sep 5 2020, 9:36 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.8; 2020-09-08).Sep 5 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 5 2020, 10:10 AM

Jdlrobson moved this task from Responsive MonoBook to Responsive on the MonoBook board.Jan 22 2021, 1:27 AM

Jdlrobson edited projects, added MonoBook (Responsive); removed MonoBook.

Jdlrobson closed this task as a duplicate of T285492: MonoBook uses 5 ResourceLoader modules, only needs 2..Thu, Jul 1, 10:47 PM