Page MenuHomePhabricator

skins.monobook.mobile.uls dependency doesn't do mobile?
Closed, DuplicatePublic

Description

Running tests/phpunit/structure/ResourcesTest.php on master, I get:

1) ResourcesTest::testUnsatisfiableDependencies
The module 'skins.monobook.mobile.uls' must not have target 'mobile' because its dependency 'ext.uls.interface' does not have it
Failed asserting that an array contains 'mobile'.

Event Timeline

So I guess the question is, is this depending on the wrong module, or should it not even be in mobile anymore, or... what?

What was this for?

Change 618401 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MonoBook@master] Refactor: Simplify responsive Monobook's optional dependencies

https://gerrit.wikimedia.org/r/618401

Change 618401 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Refactor: Simplify responsive Monobook's optional dependencies

https://gerrit.wikimedia.org/r/618401