Page MenuHomePhabricator
Create Task
Maniphest T203076

PHP Error in JsonConfig extension "Undefined property: stdClass::$zoom in includes/JCMapDataContent.php"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Notice: Undefined property: stdClass::$zoom in /srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCMapDataContent.php on line 12

Apparently from https://en.wikipedia.org/w/api.php?format=json&formatversion=2&action=jsondata&title=Harris+Park+%26+Parramatta+railway+station+markers.map

includes/JCMapDataContent.php is related to Maps content / Maps (Kartographer)

#0 /srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCMapDataContent.php(127): MWExceptionHandler::handleError(integer, string, string, integer, array, array)
#1 /srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCDataContent.php(57): JsonConfig\JCMapDataContent->localizeData(stdClass, LanguageEn)
#2 /srv/mediawiki/php-1.32.0-wmf.18/extensions/JsonConfig/includes/JCDataApi.php(32): JsonConfig\JCDataContent->getLocalizedData(LanguageEn)
#3 /srv/mediawiki/php-1.32.0-wmf.18/includes/api/ApiMain.php(1577): JsonConfig\JCDataApi->execute()
#4 /srv/mediawiki/php-1.32.0-wmf.18/includes/api/ApiMain.php(531): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.32.0-wmf.18/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.32.0-wmf.18/api.php(83): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): include(string)
#8 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Unit testing for JCMapDataContentmediawiki/extensions/JsonConfigmaster+126 -4
Making map data content fields optionalmediawiki/extensions/JsonConfigmaster+9 -3
Customize query in gerrit

Event Timeline

hashar created this task.Aug 29 2018, 11:18 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2018, 11:18 AM
Krinkle renamed this task from JsonConfig PHP Notice: Undefined property: stdClass::$zoom in includes/JCMapDataContent.php to PHP Error in JsonConfig extension "Undefined property: stdClass::$zoom in includes/JCMapDataContent.php".Aug 29 2018, 9:05 PM
Krinkle added a project: Discovery-ARCHIVED.
Krinkle moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
• Jhernandez moved this task from Unsorted to Tracking on the Maps (Kartographer) board.Sep 11 2018, 3:29 PM
• Jhernandez edited projects, added Product-Infrastructure-Team-Backlog-Deprecated; removed Discovery-ARCHIVED.
• Jhernandez added subscribers: MSantos, • Jhernandez.

@MSantos will look at this and the frequency of the errors.

MSantos claimed this task.Sep 11 2018, 3:30 PM
• Jhernandez added a subscriber: Gehel.Sep 11 2018, 3:32 PM

@Gehel checked and it seems low frequency: https://logstash.wikimedia.org/goto/908d53aae57f35808ab0c12b6e79764f

gerritbot subscribed.Sep 12 2018, 7:44 PM

Change 460084 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/JsonConfig@master] Making map data content fields optional

https://gerrit.wikimedia.org/r/460084

gerritbot added a project: Patch-For-Review.Sep 12 2018, 7:44 PM
MSantos added a comment.Sep 12 2018, 7:44 PM

Also, the problems happened because the JSON data doesn't have the zoom property. Which should be optional according to the documentation. I am submitting a fix since it was really quick to solve.

Krinkle moved this task from Dec2019/1.35.wmf.10+ to Apr 2019 / 1.33.wmf.25+ on the Wikimedia-production-error board.Sep 12 2018, 10:08 PM
• Mholloway subscribed.Sep 13 2018, 5:22 AM
Krinkle moved this task from Apr 2019 / 1.33.wmf.25+ to Older on the Wikimedia-production-error board.Sep 19 2018, 1:21 AM
MSantos triaged this task as Low priority.Sep 25 2018, 7:29 PM
MSantos moved this task from Needs triage to Backlog on the Product-Infrastructure-Team-Backlog-Deprecated board.
gerritbot added a comment.Sep 26 2018, 6:34 PM

Change 463127 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/JsonConfig@master] Unit testing for JCMapDataContent

https://gerrit.wikimedia.org/r/463127

• Mholloway edited projects, added Product-Infrastructure-Team-Backlog-Deprecated (Kanban); removed Patch-For-Review, Product-Infrastructure-Team-Backlog-Deprecated.Oct 2 2018, 11:27 AM
• Mholloway moved this task from To Do to To Deploy on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.
gerritbot added a comment.Oct 2 2018, 11:37 AM

Change 460084 merged by jenkins-bot:
[mediawiki/extensions/JsonConfig@master] Making map data content fields optional

https://gerrit.wikimedia.org/r/460084

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)).Oct 2 2018, 12:00 PM
MSantos moved this task from To Deploy to Sign off on the Product-Infrastructure-Team-Backlog-Deprecated (Kanban) board.Oct 4 2018, 8:17 PM
MSantos closed this task as Resolved.Oct 9 2018, 4:59 PM

The error is not happening since deployment, see: https://logstash.wikimedia.org/app/kibana#/dashboard/mediawiki-errors?_g=h@8525ade&_a=h@b6670d5

I am closing it as resolved but feel free to reopen if needed.

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
gerritbot added a comment.Mar 17 2020, 9:36 PM

Change 463127 had a related patch set uploaded (by TheDJ; owner: MSantos):
[mediawiki/extensions/JsonConfig@master] Unit testing for JCMapDataContent

https://gerrit.wikimedia.org/r/463127

gerritbot added a project: Patch-For-Review.Mar 17 2020, 9:36 PM
gerritbot added a comment.May 28 2025, 3:50 PM

Change #463127 abandoned by Jdlrobson:

[mediawiki/extensions/JsonConfig@master] Unit testing for JCMapDataContent

https://gerrit.wikimedia.org/r/463127

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits