Page MenuHomePhabricator

Change mentions of wp10 to articlequality in products
Closed, ResolvedPublic

Description

Related Objects

Event Timeline

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptAug 29 2018, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 456129 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani):
[mediawiki/extensions/ORES@master] Rename wp10 to articlequality

https://gerrit.wikimedia.org/r/456129

There's probably config patches needed for betalabs and prod. Did you plan on making those?

There's probably config patches needed for betalabs and prod. Did you plan on making those?

Yes, that's true.

There's probably config patches needed for betalabs and prod. Did you plan on making those?

What config patches do we need? Note that config patches do not ride the train, they are applied to all wikis at the same time. If we really need to, we can put something like if ( version_compare( $wgVersion, ...) ) { one thing } else { another thing } in CommonSettings.php, but it would be better to avoid that. It looks like there's some backwards compatibility stuff here where both the old name and the new name are supported, are you planning to use that?

It would be good to have these config patches written first, so that we can see whether they need to be applied before or after the ORES and PageTriage patches are merged and deployed.

There's probably config patches needed for betalabs and prod. Did you plan on making those?

What config patches do we need? Note that config patches do not ride the train, they are applied to all wikis at the same time. If we really need to, we can put something like if ( version_compare( $wgVersion, ...) ) { one thing } else { another thing } in CommonSettings.php, but it would be better to avoid that. It looks like there's some backwards compatibility stuff here where both the old name and the new name are supported, are you planning to use that?
It would be good to have these config patches written first, so that we can see whether they need to be applied before or after the ORES and PageTriage patches are merged and deployed.

My plan is after my patch got deployed, I just can swich off "wp10" model and switch on "articlequality" in the mediawiki-config. It'll cause two different model rows in ores_model and thus lose of data in ores_classification but we do this all the time with new version of models anyway.

Wouldn't articlequality need to be switched on before your patch is deployed, and wp10 switched off after, so that we have both of them enabled while the ORES and PageTriage patches roll out?

Wouldn't articlequality need to be switched on before your patch is deployed, and wp10 switched off after, so that we have both of them enabled while the ORES and PageTriage patches roll out?

no, as far as I can see. Deploying my patch in ORES extension should not affect anything in prod but we can't turn on articlequality and turn off wp10 (in mediawiki-config) when this patch is not deployed because it provides the mapping between class names and values. In the code nothing is dependent to the name of the model (due to the fact I rewrote most of the extension solely for making it more model-agnostic). Do you want to double check to see if I missed anything?

I see, your ORES patch adds articlequality but does not remove wp10, so it should be safe to deploy with or without the PageTriage patch, right?

Yes, that's true but looking at the PageTriage patch it definitely depends on my patch.

Change 456129 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Rename wp10 to articlequality

https://gerrit.wikimedia.org/r/456129

Change 461715 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[operations/mediawiki-config@master] Duplicate wp10 configuration into articlequality

https://gerrit.wikimedia.org/r/461715

Change 461734 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[operations/mediawiki-config@master] Labs: Duplicate wp10 configuration into articlequality

https://gerrit.wikimedia.org/r/461734

Change 461734 merged by jenkins-bot:
[operations/mediawiki-config@master] Labs: rename wp10 to articlequality

https://gerrit.wikimedia.org/r/461734

Change 461715 merged by jenkins-bot:
[operations/mediawiki-config@master] Rename wp10 to articlequality

https://gerrit.wikimedia.org/r/461715

Change 469480 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/ORES@master] Remove last remnants of wp10

https://gerrit.wikimedia.org/r/469480

Ladsgroup closed this task as Resolved.Feb 21 2019, 7:17 PM

Change 469480 abandoned by Sbisson:
Remove last remnants of wp10

https://gerrit.wikimedia.org/r/469480