Maniphest T203100

Continue webpack + test transition of mobile.startup
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

We will continue the work of switching our code to webpack scoping to the files in the acceptance criteria

Acceptance criteria

Note: Adding additional test coverage is out of scope and will be added separately.
Note, the View code has dependencies on templates so these may need to be retained as QUnit tests.

^^ View.js was migrated but the tests were saved for a future card and need further discussion (T204786)

Sign off steps

Measure and record code coverage on the wiki page

Details

Subject	Repo	Branch	Lines +/-
Migrate View.js to webpack	mediawiki/extensions/MobileFrontend	master	+527 -520
Fix dist/tests.mobilefrontend.js.map.json file	mediawiki/extensions/MobileFrontend	master	+1 -1
Continue webpack + test transition of mobile.startup	mediawiki/extensions/MobileFrontend	master	+526 -521

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Resolved	Jdlrobson	T195473 [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture
Resolved	Jdlrobson	T171000 [EPIC] Minerva works independently of MobileFrontend
Resolved	Jdlrobson	T166905 [EPIC] Talk about and improve our frontend code architecture
Declined	None	T144402 Extract MobileFrontend UI components to an external well documented library
Resolved	Jdlrobson	T162936 Improve developer happiness in reading web maintained extensions
Resolved	Jdlrobson	T155802 [EPIC] Build entire mobile.startup module using webpack bundler
Resolved	Jdrewniak	T203100 Continue webpack + test transition of mobile.startup

Event Timeline

Jdlrobson created this task.Aug 29 2018, 3:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 29 2018, 4:00 PM

Jdlrobson updated the task description. (Show Details)Aug 29 2018, 4:01 PM

Jdlrobson triaged this task as High priority.Aug 29 2018, 4:16 PM

Jdlrobson set the point value for this task to 5.

Jdlrobson moved this task from Backlog to Code coverage on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Aug 30 2018, 1:30 AM

Jdlrobson moved this task from Code coverage to PHP architecture on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.

Jdlrobson moved this task from PHP architecture to Code coverage on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.

Jdlrobson updated the task description. (Show Details)Aug 30 2018, 1:43 AM

ovasileva edited projects, added Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1); removed Web-Team-Backlog.Aug 31 2018, 7:51 AM

• nray claimed this task.Sep 3 2018, 3:29 PM

• nray moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

Change 458299 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Begin webpack + test transition of mobile.startup

https://gerrit.wikimedia.org/r/458299

gerritbot added a project: Patch-For-Review.Sep 5 2018, 9:14 PM

Jdlrobson added a parent task: T155802: [EPIC] Build entire mobile.startup module using webpack bundler.Sep 6 2018, 4:31 PM

Jdlrobson mentioned this in T203818: Add code coverage testing and increase test coverage for some existing mobile.startup files.Sep 7 2018, 5:09 PM

Jdlrobson moved this task from Code coverage to PHP architecture on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.Sep 7 2018, 5:13 PM

Jdlrobson moved this task from PHP architecture to Code coverage on the MobileFrontend (MobileFrontend and MinervaNeue architecture) board.

Change 458883 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate View.js to webpack

https://gerrit.wikimedia.org/r/458883

• nray moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 10 2018, 10:34 PM

Jdlrobson renamed this task from Begin webpack + test transition of mobile.startup to Continue webpack + test transition of mobile.startup.Sep 11 2018, 9:11 PM

Jdlrobson moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 11 2018, 9:16 PM

Change 458299 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Continue webpack + test transition of mobile.startup

https://gerrit.wikimedia.org/r/458299

Change 460092 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Fix dist/tests.mobilefrontend.js.map.json file

https://gerrit.wikimedia.org/r/460092

Change 460092 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix dist/tests.mobilefrontend.js.map.json file

https://gerrit.wikimedia.org/r/460092

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 12 2018, 9:00 PM

• nray moved this task from Doing to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 17 2018, 4:52 PM

Jdlrobson updated the task description. (Show Details)Sep 18 2018, 12:42 AM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.

Change 461145 had a related patch set uploaded (by Nray; owner: Nray):
[mediawiki/extensions/MobileFrontend@master] Migrate View.js to webpack

https://gerrit.wikimedia.org/r/461145

• nray moved this task from Needs More Work to Needs Code Review on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 18 2018, 7:06 PM

Change 461145 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Migrate View.js to webpack

https://gerrit.wikimedia.org/r/461145

• nray moved this task from Needs Code Review to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1) board.Sep 18 2018, 9:35 PM

• nray mentioned this in T204786: Migrate test_View.js to tests/node-qunit/mobile.startup.Sep 18 2018, 11:40 PM

• nray updated the task description. (Show Details)Sep 19 2018, 5:45 PM

• nray updated the task description. (Show Details)

I chatted with @nray after standup and we feel like the remaining work is captured in T204786, which we will discuss on Monday as a group (and then later estimate/tackle as deemed necessary).

There are too many challenges here and it would be good to port some other files (e.g. T203817) to get more information about what will be needed.

Looking for a signer-offer to go over the existing code and comb through T204786 to confirm this can be resolved.

Jdlrobson mentioned this in T204885: MobileFrontend's headless qunit tests need Sinon support.Sep 19 2018, 9:32 PM

• nray removed • nray as the assignee of this task.Sep 20 2018, 5:15 PM

• nray subscribed.

ovasileva assigned this task to Jdrewniak.Sep 24 2018, 5:18 PM

Jdrewniak closed this task as Resolved.Sep 26 2018, 11:47 AM

Continue webpack + test transition of mobile.startupClosed, ResolvedPublic5 Estimated Story PointsActions